From e744c1e4836322f2e1b6dbd213cda541eeba12b5 Mon Sep 17 00:00:00 2001 From: Gergely Csatari Date: Fri, 27 Mar 2026 19:10:14 +0100 Subject: [PATCH 1/2] Update CONTRIBUTING file with PR review rules Plus fixing some broken links. Signed-off-by: Gergely Csatari --- CONTRIBUTING.md | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 511a9f5697..6abcfdc3c7 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -57,6 +57,14 @@ All submissions, including submissions by project members, require review. We use GitHub pull requests for this purpose. Consult [GitHub Help] for more information on using pull requests. +Process for Code reviews, before a “human” code review a PR: + +* Must have all tests passing +* Must have all linting passing +* Must meet code quality criteria (coverage etc) +* Must have all automatically generated comments addressed (AI generated comments, SonarCloud comments, bot generated comments etc) +* If it is not possible to resolve an automatic comment, please add a sub-comment indicating why the automated comment cannot be resolved or ask for help in resolving the comment + ## Community Guidelines This project follows a [Code of Conduct]. @@ -126,7 +134,7 @@ It's usually a good idea to test locally for the following: #### Update docs -Docs are under [documentation/]. Refer to (the README,md)[documentation/README.md] in the folder to details about +Docs are under [documentation/](documentation/). Refer to the [README.md](documentation/README.md) in the folder to details about documentation contributions. From f85956b66caf0aeb0195caab484ce9bd43bbf8b6 Mon Sep 17 00:00:00 2001 From: Gergely Csatari Date: Fri, 27 Mar 2026 21:13:01 +0200 Subject: [PATCH 2/2] Apply suggestions from code review Signed-off-by: Gergely Csatari Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- CONTRIBUTING.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6abcfdc3c7..46330a6d14 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -57,11 +57,11 @@ All submissions, including submissions by project members, require review. We use GitHub pull requests for this purpose. Consult [GitHub Help] for more information on using pull requests. -Process for Code reviews, before a “human” code review a PR: +Process for code reviews. Before requesting human review, a PR must: * Must have all tests passing * Must have all linting passing -* Must meet code quality criteria (coverage etc) +* Must meet project code quality requirements, including passing all configured static analysis / SonarCloud quality gates and not reducing automated test coverage for the affected components * Must have all automatically generated comments addressed (AI generated comments, SonarCloud comments, bot generated comments etc) * If it is not possible to resolve an automatic comment, please add a sub-comment indicating why the automated comment cannot be resolved or ask for help in resolving the comment @@ -134,7 +134,7 @@ It's usually a good idea to test locally for the following: #### Update docs -Docs are under [documentation/](documentation/). Refer to the [README.md](documentation/README.md) in the folder to details about +Docs are under [documentation/](documentation/). Refer to the [README.md](documentation/README.md) in the folder for details about documentation contributions.