pet exec always uses /bin/sh?

[marcopaganini]

Hello,

Looking at the code in:

pet/cmd/util_unix.go

Line 19 in b6ecc50

cmd = exec.Command("sh", "-c", command)

It appears that pet exec always uses /bin/sh -c to execute commands. In many linux systems, /bin/sh is symlinked to /bin/dash which is the basic bourne shell. Since I use bash (and most don't use dash, I suppose), does it make sense to execute commands using /bin/sh? Many of my one-liners use bash constructs, so this makes pet unusable for those.

Any specific reasons why pet uses /bin/sh here?

[RamiAwar]

I feel like I've seen this same issue before somewhere but can't find it.

I think we can definitely extract this into global config. Some people might want different shells, makes sense!

[marcopaganini]

Thanks! One workaround for people using Debian based distributions is to uninstall dash (`sudo apt remove --purge dash`). This makes bash the main shell and things work again.

…

On Fri, Aug 16, 2024 at 8:33 AM Rami Awar ***@***.***> wrote: I feel like I've seen this same issue before somewhere but can't find it. I think we can definitely extract this into global config. Some people might want different shells, makes sense! — Reply to this email directly, view it on GitHub <#313 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYUYBDKVRKPAXZA4GM34MLZRYLV5AVCNFSM6AAAAABMMV4GHSVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTAMZWGA2DMMY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[RamiAwar]

Indeed this is configurable with the 'cmd' global config parameter! @marcopaganini

Cmd = ["/bin/dash", "-c"]

or similar.