check negative rollover; better handle errors

Author: ingon

index/format.go

@@ -88,12 +88,16 @@ func (w *Writer) SyncAndClose() error {
 	return w.Close()
 }
 
-func Write(path string, opts Params, index []Item) error {
+func Write(path string, opts Params, index []Item) (retErr error) {
 	w, err := OpenWriter(path, opts)
 	if err != nil {
 		return err
 	}
-	defer func() { _ = w.Close() }() // ignoring since its only applicable if an error has happened
+	defer func() {
+		if retErr != nil {
+			_ = w.Close()
+		}
+	}()
 
 	for _, item := range index {
 		if err := w.Write(item); err != nil {

log.go

@@ -23,7 +23,7 @@ var errDeleteRelative = fmt.Errorf("%w: delete relative offsets", message.ErrInv
 
 // Open opens or creates a [Log] based on a dir and set of options
 func Open(dir string, opts Options) (result Log, err error) {
-	if opts.Rollover == 0 {
+	if opts.Rollover <= 0 {
 		opts.Rollover = 1024 * 1024
 	}
 

typed_blocking.go

@@ -47,7 +47,7 @@ func (l *tlogBlocking[K, V]) Publish(tmessages []TMessage[K, V]) (int64, error)
 	}
 
 	l.notify.Set(nextOffset)
-	return nextOffset, err
+	return nextOffset, nil
 }
 
 func (l *tlogBlocking[K, V]) ConsumeBlocking(ctx context.Context, offset int64, maxCount int64) (int64, []TMessage[K, V], error) {