save effective rate in tax invoice items

Author: vlaskhilkevich

src/test/java/org/killbill/billing/plugin/vertex/VertexTaxCalculatorTest.java

@@ -194,32 +194,6 @@ public void testComputeDryRun() throws Exception {
         verify(vertexApiClient).calculateTaxes(argThat(arg -> SaleMessageTypeEnum.QUOTATION.equals(arg.getSaleMessageType())));
     }
 
-    @Test(groups = "fast")
-    public void testTaxEffectiveRate() throws Exception {
-        //given
-        given(invoice.getInvoiceItems()).willReturn(Collections.singletonList(taxableInvoiceItem));
-        given(taxResponse.getData()).willReturn(apiResponseData);
-        final TaxesType taxesType = new TaxesType();
-        taxesType.setCalculatedTax(MOCK_TAX_AMOUNT_1_01);
-        given(responseLineItem.getTaxes()).willReturn(Collections.singletonList(taxesType));
-
-        //given tax effective rate is present
-        taxesType.setEffectiveRate(0.09975d);
-
-        //then it persisted in item details invoice item field
-        List<InvoiceItem> result = vertexTaxCalculator.compute(account, invoice, true, Collections.emptyList(), tenantContext);
-        assertEquals("0.09975", result.get(0).getItemDetails());
-        checkTaxItemFields(result.get(0));
-
-        //given effective rate is not present
-        taxesType.setEffectiveRate(null);
-
-        //then no item details persisted
-        result = vertexTaxCalculator.compute(account, invoice, true, Collections.emptyList(), tenantContext);
-        assertNull(result.get(0).getItemDetails());
-        checkTaxItemFields(result.get(0));
-    }
-
     @Test(groups = "fast")
     public void testTaxDescription() throws Exception {
         //given
@@ -257,6 +231,32 @@ public void testTaxDescription() throws Exception {
         assertEquals("CA STATE TAX", result.get(0).getDescription());
     }
 
+    @Test(groups = "fast")
+    public void testTaxEffectiveRate() throws Exception {
+        //given
+        given(invoice.getInvoiceItems()).willReturn(Collections.singletonList(taxableInvoiceItem));
+        given(taxResponse.getData()).willReturn(apiResponseData);
+        final TaxesType taxesType = new TaxesType();
+        taxesType.setCalculatedTax(MOCK_TAX_AMOUNT_1_01);
+        given(responseLineItem.getTaxes()).willReturn(Collections.singletonList(taxesType));
+
+        //given tax effective rate is present
+        taxesType.setEffectiveRate(0.09975d);
+
+        //then it persisted in item details invoice item field
+        List<InvoiceItem> result = vertexTaxCalculator.compute(account, invoice, true, Collections.emptyList(), tenantContext);
+        assertEquals("0.09975", result.get(0).getItemDetails());
+        checkTaxItemFields(result.get(0));
+
+        //given effective rate is not present
+        taxesType.setEffectiveRate(null);
+
+        //then no item details persisted
+        result = vertexTaxCalculator.compute(account, invoice, true, Collections.emptyList(), tenantContext);
+        assertNull(result.get(0).getItemDetails());
+        checkTaxItemFields(result.get(0));
+    }
+
     private void checkTaxItemFields(final InvoiceItem taxItem) {
         assertEquals(InvoiceItemType.TAX, taxItem.getInvoiceItemType());
         assertEquals("Tax", taxItem.getDescription());