Skip to content

Commit e49102f

Browse files
committed
Don't use npm update before publication
In our projects we use `npm update` to resolve latest versions for prerelease packages from `@keep-network` scope that the current project depends on. In case of `sortition-pools` there are no dependencies to any contracts so we don't need to use `npm update`. What plain `npm update` did was updating all the packages we defined in dependencies that could cause problems as we were testing agains specific versions locked in package-lock and also CI executed it's tests agains them but here at the very last step before package publication we updated locked versions. If we need to update contracts dependencies in prerelease cycle we should specify which packages we want to update, e.g. `npm update @keep-network/sortition-pools`.
1 parent 5d77d5f commit e49102f

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

.github/workflows/npm.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,6 @@ jobs:
6666
# Consider including commit id? Would be +<commit id>.
6767
npm version prerelease --preid=$preid --no-git-tag-version
6868
69-
# Fix resolved dependency versions.
70-
npm update
71-
7269
- name: Publish package
7370
run: npm publish --access public
7471
env:

0 commit comments

Comments
 (0)