Skip to content

Commit cf1ce33

Browse files
committed
use poa_ for return_components=True after pvlib#2627
1 parent 6e23585 commit cf1ce33

2 files changed

Lines changed: 10 additions & 6 deletions

File tree

pvlib/bifacial/ants2d.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,9 @@ def _ants2d_singleside(tracker_rotation, cos_aoi, phi, gcr, height, pitch,
164164
165165
References
166166
----------
167-
.. [1] TODO
167+
.. [1] K. S. Anderson, A. R. Jensen, and C. W. Hansen, "A Bifacial View
168+
Factor Model Considering Terrain Slope and Nonuniform Albedo,"
169+
IEEE JPV, 2026. :doi:`10.1109/JPHOTOV.2026.3677506`
168170
"""
169171
# reminder of base dimensions: ground segment, row segment, time
170172

@@ -235,14 +237,14 @@ def _apply_sky_diffuse_model(dni, dhi, model, solar_zenith, solar_azimuth,
235237
# circumsolar_horizontal from DHI
236238
sky_diffuse_comps_horizontal = diffuse_model_func(
237239
surface_tilt=0, surface_azimuth=180, **kwargs, **extra_kwargs)
238-
circumsolar_horizontal = sky_diffuse_comps_horizontal['circumsolar']
240+
circumsolar_horizontal = sky_diffuse_comps_horizontal['poa_circumsolar']
239241

240242
# Call the model a second time where circumsolar_normal is facing
241243
# directly towards sun, and can be added to DNI
242244
sky_diffuse_comps_normal = diffuse_model_func(
243245
surface_tilt=solar_zenith, surface_azimuth=solar_azimuth,
244246
**kwargs, **extra_kwargs)
245-
circumsolar_normal = sky_diffuse_comps_normal['circumsolar']
247+
circumsolar_normal = sky_diffuse_comps_normal['poa_circumsolar']
246248

247249
dhi = dhi - circumsolar_horizontal
248250
dni = dni + circumsolar_normal
@@ -424,7 +426,9 @@ def get_irradiance(tracker_rotation, axis_azimuth, solar_zenith, solar_azimuth,
424426
425427
References
426428
----------
427-
.. [1] TODO
429+
.. [1] K. S. Anderson, A. R. Jensen, and C. W. Hansen, "A Bifacial View
430+
Factor Model Considering Terrain Slope and Nonuniform Albedo,"
431+
IEEE JPV, 2026. :doi:`10.1109/JPHOTOV.2026.3677506`
428432
"""
429433

430434
# so we can return scalars out if needed

tests/bifacial/test_ants2d.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@ def test__apply_sky_diffuse_model(model):
7272
kwargs['surface_azimuth'],
7373
kwargs['solar_zenith'],
7474
kwargs['solar_azimuth'])
75-
poa_direct = inputs['dni'] * aoi_proj + diffuse['circumsolar']
76-
poa_sky_diffuse = diffuse['isotropic']
75+
poa_direct = inputs['dni'] * aoi_proj + diffuse['poa_circumsolar']
76+
poa_sky_diffuse = diffuse['poa_isotropic']
7777
poa_ground = 1000 * 0.25 * (1 - pvlib.tools.cosd(20)) / 2
7878
assert adj['poa_direct'] == pytest.approx(poa_direct, abs=1e-10)
7979
assert adj['poa_sky_diffuse'] == pytest.approx(poa_sky_diffuse, abs=1e-10)

0 commit comments

Comments
 (0)