From 9cb0cdc9d3452aca2b12e855fc5b742ff364c77d Mon Sep 17 00:00:00 2001 From: ekam-walia <164983405+ekam-walia@users.noreply.github.com> Date: Thu, 27 Aug 2026 08:38:02 +0530 Subject: [PATCH 1/2] Fix(bug): KRT FilterObjectName ignores namespace in collectionReader.fetchObject() Signed-off-by: ekam-walia <164983405+ekam-walia@users.noreply.github.com> --- go/core/v2/controller/reader.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/go/core/v2/controller/reader.go b/go/core/v2/controller/reader.go index 597e5d3e0..dac917da9 100644 --- a/go/core/v2/controller/reader.go +++ b/go/core/v2/controller/reader.go @@ -71,10 +71,10 @@ func (r collectionReader) Get(_ context.Context, key types.NamespacedName, objec } func (r collectionReader) fetchObject[T controllers.ComparableObject](collection krt.Collection[T], key types.NamespacedName, resource schema.GroupResource) (T, error) { - object := krt.FetchOne(r.ctx, collection, krt.FilterObjectName(key)) - if object == nil { - var zero T - return zero, apierrors.NewNotFound(resource, key.Name) - } - return *object, nil + object := krt.FetchOne(r.ctx, collection, krt.FilterNamespace(key.Namespace), krt.FilterName(key.Name)) + if object == nil { + var zero T + return zero, apierrors.NewNotFound(resource, key.Name) + } + return *object, nil } From f01815add739c30ebc31a180635536a7a03fe4e8 Mon Sep 17 00:00:00 2001 From: ekam-walia <164983405+ekam-walia@users.noreply.github.com> Date: Thu, 27 Aug 2026 08:41:13 +0530 Subject: [PATCH 2/2] Indentation Fix Signed-off-by: ekam-walia <164983405+ekam-walia@users.noreply.github.com> --- go/core/v2/controller/reader.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/go/core/v2/controller/reader.go b/go/core/v2/controller/reader.go index dac917da9..84b0ef490 100644 --- a/go/core/v2/controller/reader.go +++ b/go/core/v2/controller/reader.go @@ -71,10 +71,10 @@ func (r collectionReader) Get(_ context.Context, key types.NamespacedName, objec } func (r collectionReader) fetchObject[T controllers.ComparableObject](collection krt.Collection[T], key types.NamespacedName, resource schema.GroupResource) (T, error) { - object := krt.FetchOne(r.ctx, collection, krt.FilterNamespace(key.Namespace), krt.FilterName(key.Name)) - if object == nil { - var zero T - return zero, apierrors.NewNotFound(resource, key.Name) - } - return *object, nil + object := krt.FetchOne(r.ctx, collection, krt.FilterNamespace(key.Namespace), krt.FilterName(key.Name)) + if object == nil { + var zero T + return zero, apierrors.NewNotFound(resource, key.Name) + } + return *object, nil }