[BUG] Declarative Agent is internally bound to BYO Agent tools. Deleting BYO Agent can still provide services.

[meetwangdk]

📋 Prerequisites

• I have searched the existing issues to avoid creating a duplicate
• By submitting this issue, you agree to follow our Code of Conduct
• I am using the latest version of the software
• I have tried to clear cache/cookies or used incognito mode (if ui-related)
• I can consistently reproduce this issue

🎯 Affected Service(s)

Not Sure

🚦 Impact/Severity

No impact (Default)

🐛 Bug Description

In my Declarative Agent, after binding a BYO agent's Tool tool, it can provide services normally, but why, after I delete the bound BYO Agent and directly delete the Agent, BYO is still providing services?

🔄 Steps To Reproduce

1. Create a Declarativer

2. Bind a BYO Agent internally

3. Create

4. Ask questions and provide services

5. Deleting BYO Agent (deleting the agent itself) does not mean deleting the agent: the configuration in tool&agent

6. Ask the question again

7. Services can still be provided

🤔 Expected Behavior

Declarative Agent is internally bound to BYO Agent tools. After the BYO Agent is deleted, the BYO Agent tools inside the original Declarative Agent should not provide services, right?

📱 Actual Behavior

No response

💻 Environment

No response

🔧 CLI Bug Report

No response

🔍 Additional Context

No response

📋 Logs

📷 Screenshots

No response

🙋 Are you willing to contribute?

• I am willing to submit a PR to fix this issue

[supreme-gg-gg]

Thanks for reporting this, I can confirm I can reproduce with declarative agent as tools as well. The declarative agent will try to reach a subagent that no longer exists. I believe a solution is to add a watch for agent, find all agents referencing this agent as subagent, reconcile them again (modify config and restart the pod) similar to how we watches for MCP servers and model config in agent_controller.go:

However, it seem like currently when translating MCP servers and agents it will just fail if it does not exist:

// adk_api_translator.go
toolAgent := &v1alpha2.Agent{}
    err := a.kube.Get(ctx, agentRef, toolAgent)
    if err != nil {
         return nil, nil, nil, err
    }

In order for it to work like your expected behaviour, we likely have to change this to "fail gracefully" and just exclude that field in the config if it doesn't exist (e.g. just deleted). This way if you delete a BYO / Declarative subagent (and similarly MCP tools) it will restart the agent with a new config that excludes it.

@EItanya what do you think