rename: Highest DPS → Highest Damage Done (#179)

* rename: Highest DPS → Highest Damage Done

Rename biggestHit to highestDamageDone across UI label, data property,
composable, fetch script, and tests. Also fix test that checked for a
non-existent ability field.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: skip data tests when fetched JSON files are missing

Since PR #178 gitignored wcl-stats.json and rio-mythicplus.json, these
tests fail in CI or local environments without API credentials. Use
describe.skipIf to gracefully skip when files don't exist, and read via
fs instead of import to avoid Vite resolve errors.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Kaan Karaoglu <9263013+kaankaraoglu@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: kaankaraoglu

scripts/fetch-wcl-stats.js

@@ -4,7 +4,7 @@
  * Writes to src/data/wcl-stats.json with:
  * - Most Deaths: player with the highest total deaths across all reports
  * - Iron Raider: player who attended the most kills without ever dying
- * - Biggest Hit: highest single-report damage total by any one player
+ * - Highest Damage Done: highest single-report damage total by any one player
  *
  * Requires WCL_CLIENT_ID and WCL_CLIENT_SECRET env vars.
  * Usage: node scripts/fetch-wcl-stats.js
@@ -30,7 +30,7 @@ const EMPTY_OUTPUT = {
   stats: {
     mostDeaths: null,
     ironRaider: null,
-    biggestHit: null,
+    highestDamageDone: null,
     bestHealer: null,
   },
 }
@@ -249,7 +249,7 @@ async function fetchStats(token) {
   const killAttendanceByName = new Map()
 
   /** @type {{ name: string, type: string, total: number, reportCode: string, bossName: string } | null} */
-  let biggestHitEntry = null
+  let highestDamageDoneEntry = null
 
   /** @type {{ name: string, type: string, total: number, reportCode: string, bossName: string } | null} */
   let bestHealerEntry = null
@@ -280,7 +280,7 @@ async function fetchStats(token) {
           }
         }
 
-        // Track biggest hit and best healer — query per individual boss fight
+        // Track highest damage done and best healer — query per individual boss fight
         // so we get highest single-fight values, not summed across all fights
         for (const fight of bossFights) {
           const [fightDamage, fightHealing] = await Promise.all([
@@ -291,8 +291,8 @@ async function fetchStats(token) {
           for (const entry of fightDamage) {
             const total = entry.total ?? entry.amount ?? 0
             if (!entry.name || total === 0) continue
-            if (!biggestHitEntry || total > biggestHitEntry.total) {
-              biggestHitEntry = {
+            if (!highestDamageDoneEntry || total > highestDamageDoneEntry.total) {
+              highestDamageDoneEntry = {
                 name: entry.name,
                 type: entry.type || '',
                 total,
@@ -369,15 +369,16 @@ async function fetchStats(token) {
     }
   }
 
-  // --- Biggest Hit ---
-  let biggestHit = null
-  if (biggestHitEntry) {
-    biggestHit = {
-      name: biggestHitEntry.name,
-      class: CLASS_MAP[biggestHitEntry.type] || biggestHitEntry.type.toLowerCase() || null,
-      amount: biggestHitEntry.total,
-      boss: biggestHitEntry.bossName || null,
-      report: `https://www.warcraftlogs.com/reports/${biggestHitEntry.reportCode}`,
+  // --- Highest Damage Done ---
+  let highestDamageDone = null
+  if (highestDamageDoneEntry) {
+    highestDamageDone = {
+      name: highestDamageDoneEntry.name,
+      class:
+        CLASS_MAP[highestDamageDoneEntry.type] || highestDamageDoneEntry.type.toLowerCase() || null,
+      amount: highestDamageDoneEntry.total,
+      boss: highestDamageDoneEntry.bossName || null,
+      report: `https://www.warcraftlogs.com/reports/${highestDamageDoneEntry.reportCode}`,
     }
   }
 
@@ -398,7 +399,7 @@ async function fetchStats(token) {
     stats: {
       mostDeaths,
       ironRaider,
-      biggestHit,
+      highestDamageDone,
       bestHealer,
     },
   }
@@ -418,7 +419,7 @@ async function main() {
     console.log(
       `[wcl-stats] Wrote stats: mostDeaths=${data.stats.mostDeaths?.name ?? 'none'}, ` +
         `ironRaider=${data.stats.ironRaider?.name ?? 'none'}, ` +
-        `biggestHit=${data.stats.biggestHit?.name ?? 'none'}, ` +
+        `highestDamageDone=${data.stats.highestDamageDone?.name ?? 'none'}, ` +
         `bestHealer=${data.stats.bestHealer?.name ?? 'none'}`,
     )
   } catch (err) {

src/components/RaidStatsBox.vue

@@ -36,16 +36,19 @@
       <p v-else class="stat-empty">No data yet.</p>
     </div>
     <div class="info-box info-box--no-hover stat-card">
-      <p class="stat-label">Highest DPS</p>
-      <template v-if="stats.biggestHit">
-        <p :class="['stat-name', stats.biggestHit.class]">{{ stats.biggestHit.name }}</p>
+      <p class="stat-label">Highest Damage Done</p>
+      <template v-if="stats.highestDamageDone">
+        <p :class="['stat-name', stats.highestDamageDone.class]">
+          {{ stats.highestDamageDone.name }}
+        </p>
         <p class="stat-value">
-          {{ formatNumber(stats.biggestHit.amount) }} on {{ stats.biggestHit.boss || 'a boss' }}
+          {{ formatNumber(stats.highestDamageDone.amount) }} on
+          {{ stats.highestDamageDone.boss || 'a boss' }}
         </p>
         <a
-          v-if="stats.biggestHit.report"
+          v-if="stats.highestDamageDone.report"
           class="stat-link"
-          :href="stats.biggestHit.report"
+          :href="stats.highestDamageDone.report"
           target="_blank"
           rel="noopener noreferrer"
           >View Log</a

src/composables/useRaidStats.js

@@ -3,14 +3,19 @@ import statsData from '@/data/wcl-stats.json'
 /**
  * @typedef {{ name: string, class: string, count: number }} DeathStat
  * @typedef {{ name: string, class: string, killsAttended: number }} IronRaiderStat
- * @typedef {{ name: string, class: string, amount: number, ability: string, boss: string, report?: string }} BiggestHitStat
+ * @typedef {{ name: string, class: string, amount: number, boss: string, report?: string }} HighestDamageDoneStat
  * @typedef {{ name: string, class: string, amount: number, boss: string, report?: string }} BestHealerStat
- * @typedef {{ mostDeaths: DeathStat|null, ironRaider: IronRaiderStat|null, biggestHit: BiggestHitStat|null, bestHealer: BestHealerStat|null }} RaidStats
+ * @typedef {{ mostDeaths: DeathStat|null, ironRaider: IronRaiderStat|null, highestDamageDone: HighestDamageDoneStat|null, bestHealer: BestHealerStat|null }} RaidStats
  */
 
 export function useRaidStats() {
   const stats = statsData.stats
-  const hasData = !!(stats.mostDeaths || stats.ironRaider || stats.biggestHit || stats.bestHealer)
+  const hasData = !!(
+    stats.mostDeaths ||
+    stats.ironRaider ||
+    stats.highestDamageDone ||
+    stats.bestHealer
+  )
 
   return {
     zone: statsData.zone,

src/data/__tests__/mythicplus.spec.js

@@ -1,7 +1,18 @@
-import { describe, it, expect } from 'vitest'
-import data from '../rio-mythicplus.json'
+import { describe, it, expect, beforeAll } from 'vitest'
+import { existsSync, readFileSync } from 'fs'
+import { dirname, resolve } from 'path'
+import { fileURLToPath } from 'url'
+
+const jsonPath = resolve(dirname(fileURLToPath(import.meta.url)), '..', 'rio-mythicplus.json')
+const exists = existsSync(jsonPath)
+
+describe.skipIf(!exists)('M+ data', () => {
+  /** @type {any} */
+  let data
+  beforeAll(() => {
+    data = JSON.parse(readFileSync(jsonPath, 'utf-8'))
+  })
 
-describe('M+ data', () => {
   it('has required top-level fields', () => {
     expect(data).toHaveProperty('season')
     expect(data).toHaveProperty('topRunners')

src/data/__tests__/wcl-stats.spec.js

@@ -1,13 +1,24 @@
-import { describe, it, expect } from 'vitest'
-import data from '../wcl-stats.json'
+import { describe, it, expect, beforeAll } from 'vitest'
+import { existsSync, readFileSync } from 'fs'
+import { dirname, resolve } from 'path'
+import { fileURLToPath } from 'url'
+
+const jsonPath = resolve(dirname(fileURLToPath(import.meta.url)), '..', 'wcl-stats.json')
+const exists = existsSync(jsonPath)
+
+describe.skipIf(!exists)('WCL stats data', () => {
+  /** @type {any} */
+  let data
+  beforeAll(() => {
+    data = JSON.parse(readFileSync(jsonPath, 'utf-8'))
+  })
 
-describe('WCL stats data', () => {
   it('has required top-level fields', () => {
     expect(data).toHaveProperty('zone')
     expect(data).toHaveProperty('stats')
     expect(data.stats).toHaveProperty('mostDeaths')
     expect(data.stats).toHaveProperty('ironRaider')
-    expect(data.stats).toHaveProperty('biggestHit')
+    expect(data.stats).toHaveProperty('highestDamageDone')
   })
 
   it('mostDeaths has name, class, and count when present', () => {
@@ -18,11 +29,11 @@ describe('WCL stats data', () => {
     }
   })
 
-  it('biggestHit has name, class, amount, ability, and boss when present', () => {
-    if (data.stats.biggestHit) {
-      expect(data.stats.biggestHit).toHaveProperty('name')
-      expect(data.stats.biggestHit).toHaveProperty('amount')
-      expect(data.stats.biggestHit).toHaveProperty('ability')
+  it('highestDamageDone has name, class, amount, and boss when present', () => {
+    if (data.stats.highestDamageDone) {
+      expect(data.stats.highestDamageDone).toHaveProperty('name')
+      expect(data.stats.highestDamageDone).toHaveProperty('amount')
+      expect(data.stats.highestDamageDone).toHaveProperty('boss')
     }
   })
 })