refactor: return undefined instead of throwing an exception from getRow()

Author: jrentlez

libs/execution/src/lib/debugging/debug-log-visitor.ts

@@ -20,6 +20,8 @@ import { type Table } from '../types/io-types/table';
 import { findLineBounds } from '../util/string-util';
 
 import { type DebugGranularity } from './debug-configuration';
+// eslint-disable-next-line unicorn/prefer-node-protocol
+import assert from 'assert';
 
 export class DebugLogVisitor implements IoTypeVisitor<void> {
   private readonly PEEK_NUMBER_OF_WORKBOOKS = 5;
@@ -57,6 +59,7 @@ export class DebugLogVisitor implements IoTypeVisitor<void> {
       }
 
       const row = table.getRow(i);
+      assert(row !== undefined);
       const rowData = [...row.values()]
         .map((cell) => {
           if (ERROR_TYPEGUARD(cell)) {

libs/execution/src/lib/types/io-types/table.ts

@@ -3,7 +3,7 @@
 // SPDX-License-Identifier: AGPL-3.0-only
 
 // eslint-disable-next-line unicorn/prefer-node-protocol
-import { strict as assert } from 'assert';
+import assert from 'assert';
 
 import {
   ERROR_TYPEGUARD,
@@ -126,12 +126,10 @@ export class Table implements IOTypeImplementation<IOType.TABLE> {
     return this.columns.get(name);
   }
 
-  getRow(rowId: number): TableRow {
+  getRow(rowId: number): TableRow | undefined {
     const numberOfRows = this.getNumberOfRows();
     if (rowId >= numberOfRows) {
-      throw new Error(
-        `Trying to access table row ${rowId} (of ${numberOfRows} rows)`,
-      );
+      return undefined;
     }
 
     const row = new Map<
@@ -163,6 +161,7 @@ export class Table implements IOTypeImplementation<IOType.TABLE> {
   ): void {
     for (let rowIdx = 0; rowIdx < this.numberOfRows; rowIdx++) {
       const row = this.getRow(rowIdx);
+      assert(row !== undefined);
 
       for (const constraint of this.constraints) {
         if (constraint.isValid(row, executionContext)) {