suppress double warning, handle missing class

Author: evakhoni

python/packages/jumpstarter/jumpstarter/client/client.py

@@ -1,4 +1,5 @@
 import logging
+import os
 from collections import OrderedDict, defaultdict
 from contextlib import ExitStack, asynccontextmanager
 from graphlib import TopologicalSorter
@@ -59,7 +60,9 @@ async def client_from_channel(
             client_class = import_class(report.labels["jumpstarter.dev/client"], allow, unsafe)
         except MissingDriverError as e:
             # Create stub client instead of failing
-            logger.warning("Driver client '%s' is not available.", e.class_path)
+            # Suppress duplicate warnings
+            if not os.environ.get("_JMP_SUPPRESS_DRIVER_WARNINGS"):
+                logger.warning("Driver client '%s' is not available.", e.class_path)
             client_class = StubDriverClient
 
         client = client_class(

python/packages/jumpstarter/jumpstarter/common/importlib.py

@@ -64,9 +64,20 @@ def import_class(class_path: str, allow: list[str], unsafe: bool):
     try:
         return cached_import(module_path, class_name)
     except ModuleNotFoundError as e:
+        # Only convert to MissingDriverError if the missing module is the target module itself
+        # (or a parent package of it). If it's a transitive dependency, re-raise to preserve
+        # the original error and show the real cause.
+        if e.name and (e.name == module_path or module_path.startswith(f"{e.name}.")):
+            raise MissingDriverError(
+                message=_format_missing_driver_message(class_path),
+                class_path=class_path,
+            ) from e
+        else:
+            # Transitive dependency missing - re-raise to show the real cause
+            raise
+    except AttributeError as e:
+        # Module exists but class doesn't - treat in a similar way to missing module
         raise MissingDriverError(
             message=_format_missing_driver_message(class_path),
             class_path=class_path,
         ) from e
-    except AttributeError as e:
-        raise ImportError(f"{module_path} doesn't have specified class {class_name}") from e

python/packages/jumpstarter/jumpstarter/common/importlib_test.py

@@ -1,12 +1,13 @@
 import pytest
 
+from .exceptions import MissingDriverError
 from .importlib import import_class
 
 
 def test_import_class():
     import_class("os.open", [], True)
 
-    with pytest.raises(ImportError):
+    with pytest.raises(MissingDriverError):
         import_class("os.invalid", [], True)
 
     with pytest.raises(ImportError):

python/packages/jumpstarter/jumpstarter/common/utils.py

@@ -108,6 +108,7 @@ def launch_shell(
     common_env = os.environ | {
         JUMPSTARTER_HOST: host,
         JMP_DRIVERS_ALLOW: "UNSAFE" if unsafe else ",".join(allow),
+        "_JMP_SUPPRESS_DRIVER_WARNINGS": "1",  # Already warned during client initialization
     }
 
     if command:

python/packages/jumpstarter/jumpstarter/config/exporter.py

@@ -48,7 +48,7 @@ def instantiate(self) -> Driver:
                     driver_class = import_class(self.root.type, [], True)
                 except MissingDriverError:
                     raise ConfigurationError(
-                        f"Exporter configuration: Driver '{self.root.type}' is not installed.\n\n"
+                        f"Driver '{self.root.type}' is not installed. Please check exporter configuration."
                     ) from None
 
                 children = {name: child.instantiate() for name, child in self.root.children.items()}