use the common method_description infrastructure for shell driver

eliminate the extra RPC introduced in https://github.com/jumpstarter-dev/jumpstarter/pull/685

(cherry picked from commit c1ec0c8)

Author: michalskrivanek

packages/jumpstarter-driver-shell/jumpstarter_driver_shell/client.py

@@ -75,18 +75,12 @@ def method_command(args, env):
             if returncode != 0:
                 raise click.exceptions.Exit(returncode)
 
-        # Try to get custom description, fall back to default for older than 0.7 servers
-        try:
-            description = self.call("get_method_description", method_name)
-        except Exception:
-            description = f"Execute the {method_name} shell method"
-
         # Decorate and register the command with help text
         method_command = click.argument('args', nargs=-1, type=click.UNPROCESSED)(method_command)
         method_command = click.option('--env', '-e', multiple=True,
                      help='Environment variables in KEY=VALUE format')(method_command)
         method_command = group.command(
             name=method_name,
-            help=description,
+            help=self.methods_description.get( method_name, f"Execute the {method_name} shell method"),
             context_settings={"ignore_unknown_options": True, "allow_interspersed_args": False},
         )(method_command)

packages/jumpstarter-driver-shell/jumpstarter_driver_shell/driver.py

@@ -21,20 +21,20 @@ class Shell(Driver):
     timeout: int = 300
     cwd: str | None = None
 
+    def __post_init__(self):
+        super().__post_init__()
+        # Extract descriptions from methods configuration and populate methods_description
+        for method_name, method_config in self.methods.items():
+            if isinstance(method_config, dict) and "description" in method_config:
+                self.methods_description[method_name] = method_config["description"]
+
     def _get_method_command(self, method: str) -> str:
         """Extract the command string from a method configuration"""
         method_config = self.methods[method]
         if isinstance(method_config, str):
             return method_config
         return method_config.get("command", "echo Hello")
 
-    def _get_method_description(self, method: str) -> str:
-        """Extract the description from a method configuration"""
-        method_config = self.methods[method]
-        if isinstance(method_config, str):
-            return f"Execute the {method} shell method"
-        return method_config.get("description", f"Execute the {method} shell method")
-
     def _get_method_timeout(self, method: str) -> int:
         """Extract the timeout from a method configuration, fallback to global timeout"""
         method_config = self.methods[method]
@@ -52,11 +52,6 @@ def get_methods(self) -> list[str]:
         self.logger.debug(f"get_methods called, returning methods: {methods}")
         return methods
 
-    @export
-    def get_method_description(self, method: str) -> str:
-        """Get the description for a specific method"""
-        return self._get_method_description(method)
-
     @export
     async def call_method(self, method: str, env, *args) -> AsyncGenerator[tuple[str, str, int | None], None]:
         """

packages/jumpstarter-driver-shell/jumpstarter_driver_shell/driver_test.py

@@ -199,24 +199,26 @@ def test_cli_default_descriptions():
         assert test_cmd.help == "Execute the test_method shell method"
 
 
-def test_get_method_description_unified():
-    """Test the get_method_description export method with unified format"""
+def test_methods_description_populated():
+    """Test that methods_description is populated from methods configuration"""
     shell = Shell(
         methods={
             "method1": {
                 "command": "echo",
                 "description": "Custom description for method1"
             },
-            "method2": "ls",  # String format, should use default description
+            "method2": "ls",  # String format, no description in methods_description
         }
     )
 
     with serve(shell) as client:
-        # Test with custom description (unified format)
-        assert client.call("get_method_description", "method1") == "Custom description for method1"
+        # Test that custom descriptions are in methods_description
+        assert "method1" in client.methods_description
+        assert client.methods_description["method1"] == "Custom description for method1"
 
-        # Test with default description (string format)
-        assert client.call("get_method_description", "method2") == "Execute the method2 shell method"
+        # Test that string-format methods are not in methods_description
+        # (will fall back to default in client)
+        assert "method2" not in client.methods_description
 
 
 def test_mixed_format_methods():