fix: log internal errors and return generic public messages

jtbrough · jtbrough · commit a96384ecf42d · 2026-02-27T14:18:47.000-07:00
diff --git a/server.js b/server.js
@@ -77,13 +77,12 @@ function decodeHtmlAttributeValue(input) {
 }
 
 function toPublicErrorMessage(err, fallback = 'Request failed') {
-  const message = err instanceof Error ? err.message : String(err || '');
-  const clean = message.replace(/\s+/g, ' ').trim();
-  if (!clean) return fallback;
-  if (clean.includes('\n') || /\bat\s+\S+/.test(clean) || clean.startsWith('Error:')) {
-    return fallback;
+  if (err instanceof Error) {
+    console.error('Internal error:', err.stack || err.message);
+  } else {
+    console.error('Internal error:', err);
   }
-  return clean;
+  return fallback;
 }
 
 function sendJson(res, status, data) {

Original file line number	Diff line number	Diff line change
`@@ -77,13 +77,12 @@ function decodeHtmlAttributeValue(input) {`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`function toPublicErrorMessage(err, fallback = 'Request failed') {`
`80`		`- const message = err instanceof Error ? err.message : String(err \|\| '');`
`81`		`- const clean = message.replace(/\s+/g, ' ').trim();`
`82`		`- if (!clean) return fallback;`
`83`		`- if (clean.includes('\n') \|\| /\bat\s+\S+/.test(clean) \|\| clean.startsWith('Error:')) {`
`84`		`- return fallback;`
	`80`	`+ if (err instanceof Error) {`
	`81`	`+ console.error('Internal error:', err.stack \|\| err.message);`
	`82`	`+ } else {`
	`83`	`+ console.error('Internal error:', err);`
`85`	`84`	`}`
`86`		`- return clean;`
	`85`	`+ return fallback;`
`87`	`86`	`}`
`88`	`87`
`89`	`88`	`function sendJson(res, status, data) {`