Update cmd/cli/api-node.go

javuto · Copilot · web-flow · commit 9a76195aaf67 · 2025-06-01T19:34:58.000+02:00
Use `bytes.NewReader(jsonMessage)` instead of converting to string to avoid unnecessary memory allocation.

Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/cmd/cli/api-node.go b/cmd/cli/api-node.go
@@ -74,7 +74,7 @@ func (api *OsctrlAPI) LookupNode(identifier string) (nodes.OsqueryNode, error) {
 	if err != nil {
 		return node, fmt.Errorf("error marshaling data %w", err)
 	}
-	jsonParam := strings.NewReader(string(jsonMessage))
+	jsonParam := bytes.NewReader(jsonMessage)
 	reqURL := fmt.Sprintf("%s%s%s/lookup", api.Configuration.URL, APIPath, APINodes)
 	rawNode, err := api.PostGeneric(reqURL, jsonParam)
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ func (api *OsctrlAPI) LookupNode(identifier string) (nodes.OsqueryNode, error) {`
`74`	`74`	`if err != nil {`
`75`	`75`	`return node, fmt.Errorf("error marshaling data %w", err)`
`76`	`76`	`}`
`77`		`- jsonParam := strings.NewReader(string(jsonMessage))`
	`77`	`+ jsonParam := bytes.NewReader(jsonMessage)`
`78`	`78`	`reqURL := fmt.Sprintf("%s%s%s/lookup", api.Configuration.URL, APIPath, APINodes)`
`79`	`79`	`rawNode, err := api.PostGeneric(reqURL, jsonParam)`
`80`	`80`	`if err != nil {`