auto-track-bookmarks doesn't affect imported local bookmarks

[senekor]

Description

The config option remotes.<name>.auto-track-bookmarks is only applied to local bookmarks created via jj (bookmark create & set). It is not applied to local bookmarks created via git when importing from an underlying git repo.

Steps to Reproduce the Problem

1. Configure remotes.<name>.auto-track-bookmarks to track stuff.
2. Run git branch <name> where the branch name matches the auto-track config.
3. Run jj log and observe that the imported bookmark is not auto-tracked.

Expected Behavior

Local bookmarks imported from a git repo should be affected by the auto-track configuration.

Specifications

• Platform: x86_64-unknown-linux-gnu
• Version: jj 0.36.0-70fd8f7697fbc20a9329a6e2f790ef86a8e284d1

[yuja]

Good catch.

I'm not sure what we should do for imported local and remote refs. Since import/export runs implicitly in colocated repos, it would be surprising if an arbitrary jj invocation moved local bookmarks by tracking imported remote bookmarks. This is similar to #1862. OTOH, maybe it's safe to set up tracking of imported local bookmarks when there are no existing remote bookmarks to track.

EDIT: perhaps, git::import_refs() would already have this surprising behavior for imported remote bookmarks. So this wouldn't be a new problem.

[senekor]

perhaps, git::import_refs() would already have this surprising behavior for imported remote bookmarks

Yes, I tested this and it is the case. If there is a bookmark "foo" on the remote which the local repo doesn't know about yet, and a local bookmark that's also called "foo", running jj git fetch can auto-track this bookmark and move the local one to where the remote one is pointing.

I don't think this is terribly surprising... And I think it is expected for jj git fetch to behave the same way as git fetch ; jj git import, when it comes to the auto-tracking configuration.

[yuja]

FWIW, both jj git import and jj git fetch works in the same direction, remotes to local. (The colocated Git repository is a pseudo remote named git.) If we implement auto-tracking of local bookmarks, new local bookmarks fetched and merged from one remote will also track the other remotes. I don't think this is wrong, though.