From dc526876efb4500b4281af86210f1ee0b4dd24ca Mon Sep 17 00:00:00 2001 From: Matan Eden <57892946+MatanEden1@users.noreply.github.com> Date: Tue, 7 Jul 2026 11:45:35 +0300 Subject: [PATCH] AX-1792: Remove JFROG_URL validation from SessionStart injector The check exited the hook before the Agent Guard force-enable check ran, so a missing/malformed JFROG_URL blocked sessions even when Agent Guard wasn't enabled or was force-enabled to bypass checks. Co-Authored-By: Claude Sonnet 5 --- plugin/scripts/inject-instructions.mjs | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/plugin/scripts/inject-instructions.mjs b/plugin/scripts/inject-instructions.mjs index 1539b52..a159190 100644 --- a/plugin/scripts/inject-instructions.mjs +++ b/plugin/scripts/inject-instructions.mjs @@ -114,30 +114,6 @@ if (forceDisabled) { process.exit(0); } -// Validate JFROG_URL early to surface misconfigurations before the MCP server -// attempts to connect and fails with a confusing DNS or double-slash error. -if (!process.env.JFROG_URL) { - const missingUrlWarning = "WARNING: JFROG_URL is not set. The JFrog MCP server will be unreachable — set JFROG_URL to your Artifactory base URL (e.g. https://mycompany.jfrog.io) and restart."; - log(missingUrlWarning); - process.stdout.write(JSON.stringify({ - hookSpecificOutput: { - hookEventName: "SessionStart", - additionalContext: `IMPORTANT: Immediately tell the user: "${missingUrlWarning}"`, - }, - })); - process.exit(0); -} else if (process.env.JFROG_URL.endsWith("/")) { - const trailingSlashWarning = "WARNING: JFROG_URL has a trailing slash. This produces a double-slash in the MCP URL and will silently fail — remove the trailing slash and restart."; - log(trailingSlashWarning); - process.stdout.write(JSON.stringify({ - hookSpecificOutput: { - hookEventName: "SessionStart", - additionalContext: `IMPORTANT: Immediately tell the user: "${trailingSlashWarning}"`, - }, - })); - process.exit(0); -} - if (forceEnabled) { debug("Force-enable flag is set."); } else if (!(await isAgentGuardEnabledViaSettings())) {