From 430861e93f699092788f9fb01d162cf01daa2e70 Mon Sep 17 00:00:00 2001 From: jrd Date: Fri, 31 Jul 2026 14:59:41 +0000 Subject: [PATCH] Document TARGET naming mechanisms in Jamulus.pro The two Debian packages get their binary names by different means: the desktop build passes CONFIG+=noupcasename, while the headless build passes TARGET=jamulus-headless on the qmake command line. Nothing in the file said so, and the interaction is easy to get wrong. Record where TARGET is consumed (debian/*.install, the generated .desktop Exec=, and the hardcoded ExecStart= in the headless unit) and note that the assignment in this block overrides any command-line TARGET=, so adding noupcasename to the headless build would silently rename its binary to "jamulus" and break that package. Comment only; no build behaviour changes. --- Jamulus.pro | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Jamulus.pro b/Jamulus.pro index a7e8fe0c7e..a1bf7c8876 100644 --- a/Jamulus.pro +++ b/Jamulus.pro @@ -6,6 +6,16 @@ lessThan(QT_MAJOR_VERSION, 5) | equals(QT_MAJOR_VERSION, 5) : lessThan(QT_MINOR_ error(Jamulus requires at least Qt5.12. See https://github.com/jamulussoftware/jamulus/pull/3288) } +# Target naming. The two Debian packages get their binary names by different means +# (see linux/debian/rules): the desktop build passes CONFIG+=noupcasename, handled +# here, while the headless build passes TARGET=jamulus-headless on the qmake command +# line. TARGET selects the installed usr/bin/ listed in debian/*.install and +# is substituted into Exec= in the generated .desktop files, and it has to keep +# matching the hardcoded ExecStart=/usr/bin/jamulus-headless in the headless unit. +# Note the assignment below overrides any TARGET= given on the command line, so +# adding noupcasename to the headless build would silently rename its binary to +# "jamulus" and break that package. + # use target name which does not use a capital letter at the beginning contains(CONFIG, "noupcasename") { message(The target name is jamulus instead of Jamulus.)