control flow switch recovery does not work if there's case with return in if/else

[Le0Developer]

Describe the bug

This example has a case with no trailing continue or return, so the matcher fails

webcrack/packages/webcrack/src/deobfuscate/control-flow-switch.ts

Lines 18 to 24 in 5dd3d93

	m.switchCase(
	m.stringLiteral(m.matcher((s) => /^\d+$/.test(s))),
	m.anyList(
	m.zeroOrMore(),
	m.or(m.continueStatement(), m.returnStatement()),
	),
	),

Expected Behaviour

Not sure what the ideal fix is, but I replaced the m.anyList() with m.zeroOrMore() and it seems to work.

Code

function gl() {
  var d = "0".split("|");
  var e = 0;
  while (true) {
    switch (d[e++]) {
      case "0":
        if (true) {
          return 123;
        } else {
          return 456;
        }
    }
    break;
  }
}

Logs

[j4k0xb]

Nice catch
Did you run webcrack before on this script (https://webcrack.netlify.app/docs/concepts/unminify.html#ternary-to-if)? Because normally there must be a continue or return: https://github.com/javascript-obfuscator/javascript-obfuscator/blob/828a190cf80a86227ef77be38e99aad9838aed70/src/custom-nodes/control-flow-flattening-nodes/BlockStatementControlFlowFlatteningNode.ts#L130-L142

[Le0Developer]

you are correct, it's from a ternary. the original expression is:

function gl() {
  var d = "0".split("|");
  var e = 0;
  while (true) {
    switch (d[e++]) {
      case "0":
        return i[jX(1352)] == l ? i[jX(545)](gC, e, g[h]) ? 'N' : 'f' : gB[l] || '?';
    }
    break;
  }
}

[j4k0xb]

Not sure what the ideal fix is

Deobfuscating control flow switch correctly the first time (most likely #44)
But removing m.anyList is an acceptable workaround too since the other matchers are still fairly strict
m.zeroOrMore is only intended to be used in m.anyList, can be removed as well.