Allow server restarts when CF API key is invalid

[AerikAwesome]

Enhancement Type

Improve an existing feature

Describe the enhancement

Been having an issue with Curseforge recently where my API key keeps getting invalidated. Initial install with a fresh key works fine, but on restart I get the following error:

[mc-image-helper] 20:54:05.747 ERROR : Invalid parameter provided for 'install-curseforge' command: Access to https://api.curseforge.com is forbidden or rate-limit has been exceeded. Ensure CF_API_KEY is set to a valid API key from https://console.curseforge.com/ or allow rate-limit to reset.
[init] [ERROR] Failed to auto-install CurseForge modpack (B

This can be resolved by changing my organisation name in Curseforge, regenerating an apikey, and redeploying with this new key. This is obviously not a great method.

A variable that would allow the server to continue startup when Curseforge can not be reached would be amazing.

[itzg]

Continue and do what? Run with an invalid installation? It should already be skipping lookup if you specified a specific modpack and version.

[itzg]

...I'm afraid your scenario and need for regenerating the api key is not typical. I would advise reporting an issue with CurseForge; however, I'm not sure how responsive they will be.

In other words, I'll put this in the queue but probably won't ever work on it myself. Maybe you or someone else can contribute a PR to

https://github.com/itzg/mc-image-helper/tree/master/src/main/java/me/itzg/helpers/curseforge

[AerikAwesome]

This is happening for me with a valid installation. The very first step seems to be checking in with Curseforge, and the container stops after the error reported above.

It might be possible to reproduce this by regenerating your api key while the container is running, and then restarting it.

I saw a few other issues around (on here as well) with people having issues with their api keys, I figured this might be a good way of "fixing" the worst of it

[itzg]

My apologies, no, you're not the only one but it's still a rare scenario. This works fine for many users.

I'm not going to regenerate my API key because mine has worked fine for over a year. Generating one in the middle is certainly going to break startup and doesn't reveal new information. I can look at my own code to see where API calls are being made.

As a workaround you can unset the CF_API_KEY after first installation and it will reuse the existing one with a warning.

[tealblu]

Just bumping this as I am experiencing the same issue

[itzg]

@tealblu as alluded to above, I will likely not do anything further to address this. Please look at all of the documentation to correctly use the API key, make sure you have pulled and applied the latest image. Otherwise, ask around on the Discord server since there are many others that seem to have API key issues.

[AerikAwesome]

I "resolved" this for me by creating a new Curseforge organization under an alternative email address.

I suspect repeated failure, like from an endlessly restarting container, gets you put on a blocklist. Fortunately, it doesn't seem to block you on your IP address.