From ecd77f5ca42041e602d5525e8c5364819af11479 Mon Sep 17 00:00:00 2001 From: Peter Du Date: Wed, 27 May 2026 14:54:49 -0700 Subject: [PATCH 1/2] make isaaclab_teleop a dep of isaaclab_mimic during mimic only install --- .../isaaclab/changelog.d/peterd-mimic-installs-teleop.rst | 5 +++++ source/isaaclab/isaaclab/cli/commands/install.py | 2 +- source/isaaclab/test/cli/test_install_command_parsing.py | 2 +- source/isaaclab_mimic/changelog.d/isaaclab-teleop-dep.rst | 6 ++++++ 4 files changed, 13 insertions(+), 2 deletions(-) create mode 100644 source/isaaclab/changelog.d/peterd-mimic-installs-teleop.rst create mode 100644 source/isaaclab_mimic/changelog.d/isaaclab-teleop-dep.rst diff --git a/source/isaaclab/changelog.d/peterd-mimic-installs-teleop.rst b/source/isaaclab/changelog.d/peterd-mimic-installs-teleop.rst new file mode 100644 index 000000000000..4074fe7de8de --- /dev/null +++ b/source/isaaclab/changelog.d/peterd-mimic-installs-teleop.rst @@ -0,0 +1,5 @@ +Changed +^^^^^^^ + +* ``./isaaclab.sh -i mimic`` now also installs ``isaaclab_teleop`` as an editable + submodule, since :mod:`isaaclab_mimic` declares it as a required dependency. diff --git a/source/isaaclab/isaaclab/cli/commands/install.py b/source/isaaclab/isaaclab/cli/commands/install.py index 29a774d016be..d13589e5bb54 100644 --- a/source/isaaclab/isaaclab/cli/commands/install.py +++ b/source/isaaclab/isaaclab/cli/commands/install.py @@ -487,7 +487,7 @@ def _install_isaacsim() -> None: # Optional submodules — only installed when explicitly requested or with 'all'. # Maps the short CLI name to one or more source directory names under source/. OPTIONAL_ISAACLAB_SUBMODULES: dict[str, tuple[str, ...]] = { - "mimic": ("isaaclab_mimic",), + "mimic": ("isaaclab_teleop", "isaaclab_mimic"), "teleop": ("isaaclab_teleop",), } diff --git a/source/isaaclab/test/cli/test_install_command_parsing.py b/source/isaaclab/test/cli/test_install_command_parsing.py index d0bccdae4a77..27281ec013f4 100644 --- a/source/isaaclab/test/cli/test_install_command_parsing.py +++ b/source/isaaclab/test/cli/test_install_command_parsing.py @@ -122,7 +122,7 @@ def test_core_submodules_contains_expected_packages(self): def test_optional_submodules_contains_expected_packages(self): assert set(OPTIONAL_ISAACLAB_SUBMODULES.keys()) == {"mimic", "teleop"} - assert OPTIONAL_ISAACLAB_SUBMODULES["mimic"] == ("isaaclab_mimic",) + assert OPTIONAL_ISAACLAB_SUBMODULES["mimic"] == ("isaaclab_teleop", "isaaclab_mimic") assert OPTIONAL_ISAACLAB_SUBMODULES["teleop"] == ("isaaclab_teleop",) def test_valid_extra_features(self): diff --git a/source/isaaclab_mimic/changelog.d/isaaclab-teleop-dep.rst b/source/isaaclab_mimic/changelog.d/isaaclab-teleop-dep.rst new file mode 100644 index 000000000000..07f9f6845c3b --- /dev/null +++ b/source/isaaclab_mimic/changelog.d/isaaclab-teleop-dep.rst @@ -0,0 +1,6 @@ +Changed +^^^^^^^ + +* Declared ``isaaclab_teleop`` as a required sibling extension of + ``isaaclab_mimic`` in ``config/extension.toml``. ``./isaaclab.sh -i mimic`` + now installs ``isaaclab_teleop`` alongside ``isaaclab_mimic``. From 80dd6e7a913450b5fab47a3d528fe83131e8e35e Mon Sep 17 00:00:00 2001 From: peterd-NV Date: Wed, 27 May 2026 15:04:32 -0700 Subject: [PATCH 2/2] Update isaaclab-teleop-dep.rst Signed-off-by: peterd-NV --- source/isaaclab_mimic/changelog.d/isaaclab-teleop-dep.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source/isaaclab_mimic/changelog.d/isaaclab-teleop-dep.rst b/source/isaaclab_mimic/changelog.d/isaaclab-teleop-dep.rst index 07f9f6845c3b..ca97da40b172 100644 --- a/source/isaaclab_mimic/changelog.d/isaaclab-teleop-dep.rst +++ b/source/isaaclab_mimic/changelog.d/isaaclab-teleop-dep.rst @@ -1,6 +1,6 @@ Changed ^^^^^^^ -* Declared ``isaaclab_teleop`` as a required sibling extension of - ``isaaclab_mimic`` in ``config/extension.toml``. ``./isaaclab.sh -i mimic`` +* Declared ``isaaclab_teleop`` as a required extension of + ``isaaclab_mimic`` in ``install.py``. ``./isaaclab.sh -i mimic`` now installs ``isaaclab_teleop`` alongside ``isaaclab_mimic``.