[_502] test harness and container-based tests

A new test harness is introduced in which we construct a new
container (using either Docker or podman) for each test program
we run. This allows full customization of the container
environment for the particular needs of each test.

Accordingly, included with the Github workflows (in a separate
commit) is a full run of the PRC test suite with the iRODS server
and catalog DB server running in the same container as the client.

In the process of putting old tests through new rigors, faults
were found and corrected in some of those tests.

Author: d-w-moore

Dockerfile.prc_test.centos

@@ -24,6 +24,5 @@ RUN  python${py_N} repo/docker_build/iinit.py \
         password rods
 SHELL ["/bin/bash","-c"]
 CMD  echo "Waiting on iRODS server... " ; \
-     python${PY_N} repo/docker_build/recv_oneshot -h irods-provider -p 8888 -t 360 && \
      sudo groupadd -o -g $(stat -c%g /irods_shared) irods && sudo usermod -aG irods user && \
      newgrp irods < repo/run_python_tests.sh

Dockerfile.prc_test.ubuntu

@@ -31,6 +31,5 @@ SHELL ["/bin/bash","-c"]
 #  3. run python tests as the new group
 
 CMD  echo "Waiting on iRODS server... " ; \
-     python${PY_N} repo/docker_build/recv_oneshot -h irods-provider -p 8888 -t 360 && \
      sudo groupadd -o -g $(stat -c%g /irods_shared) irods && sudo usermod -aG irods user && \
      newgrp irods < repo/run_python_tests.sh

irods/message/__init__.py

@@ -181,7 +181,7 @@ def ET(xml_type=(), server_version=None):
 
 logger = logging.getLogger(__name__)
 
-IRODS_VERSION = (5, 0, 1, "d")
+IRODS_VERSION = (5, 0, 2, "d")
 
 UNICODE = str
 

irods/test/access_test.py

@@ -533,11 +533,7 @@ def test_iRODSAccess_cannot_be_constructed_using_unsupported_type__issue_558(sel
         # Before the fix in #558, this would have been allowed and only later would the type discrepancy be revealed,
         # leading to opaque error messages. Now, the types are checked on the way in to ensure clarity and correctness.
         # TODO(#480): We cannot use the unittest.assertRaises context manager as this was introduced in python 3.1.
-        assertCall = getattr(self, "assertRaisesRegex", None)
-        if assertCall is None:
-            assertCall = self.assertRaisesRegexp
-
-        assertCall(
+        self.assertRaisesRegex(
             TypeError,
             "'path' parameter must be of type 'str', 'irods.collection.iRODSCollection', "
             "'irods.data_object.iRODSDataObject', or 'irods.path.iRODSPath'.",

irods/test/data_obj_test.py

@@ -3305,16 +3305,13 @@ def test_access_time__issue_700(self):
         if self.sess.server_version < (5,):
             self.skipTest("iRODS servers < 5.0.0 do not provide an access_time attribute for data objects.")
 
-        data_path= iRODSPath(self.coll.path,
-            unique_name(my_function_name(), datetime.now())
-            )
-        with self.sess.data_objects.open(data_path,"w") as f:
-            f.write(b'_')
-        with self.sess.data_objects.open(data_path,"r") as f:
-            f.read()
+        # Create a new, uniquely named test data object.
+        data = self.sess.data_objects.create(
+            f'{helpers.home_collection(self.sess)}/{unique_name(my_function_name(), datetime.now())}'
+        )
 
-        data = self.sess.data_objects.get(data_path)
-        self.assertGreaterEqual(data.access_time, data.modify_time)
+        # Test that access_time is there, and of the right type.
+        self.assertIs(type(data.access_time), datetime)
 
 if __name__ == "__main__":
     # let the tests find the parent irods lib

irods/test/exception_test.py

@@ -41,8 +41,8 @@ def test_400(self):
             excep_repr = repr(exc)
             errno_object = irods.exception.Errno(errno.EACCES)
             errno_repr = repr(errno_object)
-            self.assertRegexpMatches(errno_repr, r"\bErrno\b")
-            self.assertRegexpMatches(
+            self.assertRegex(errno_repr, r"\bErrno\b")
+            self.assertRegex(
                 errno_repr, """['"]{msg}['"]""".format(msg=os.strerror(errno.EACCES))
             )
             self.assertIn(errno_repr, excep_repr)

irods/test/harness/000_install-irods.Dockerfile

@@ -0,0 +1,14 @@
+FROM ubuntu:22.04
+COPY install.sh /
+ARG irods_package_version
+ENV IRODS_PACKAGE_VERSION "$irods_package_version"
+RUN for phase in initialize install-essential-packages add-package-repo; do \
+        bash /install.sh --w=$phase 0; \
+    done
+RUN /install.sh 4
+COPY start_postgresql_and_irods.sh manage_irods5_procs /
+RUN apt install -y sudo
+RUN useradd -ms/bin/bash testuser
+RUN echo 'testuser ALL=(ALL) NOPASSWD: ALL' >>/etc/sudoers
+RUN apt install -y faketime
+CMD bash /start_postgresql_and_irods.sh

irods/test/harness/001_bats-python3.Dockerfile

@@ -0,0 +1,5 @@
+FROM install-irods
+RUN apt update; apt install -y python3-pip bats
+RUN python3 -m pip install --upgrade pip
+RUN python3 -m pip install virtualenv
+RUN python3 -m virtualenv /py3

irods/test/harness/002_ssl-and-pam.Dockerfile

@@ -0,0 +1 @@
+FROM bats-python3

irods/test/harness/003_compile-specific-python.Dockerfile

@@ -0,0 +1,17 @@
+FROM ssl-and-pam
+RUN apt update
+RUN apt install -y wget build-essential
+RUN apt install -y libssl-dev zlib1g-dev libffi-dev libncurses-dev wget build-essential
+ARG python_version
+RUN wget https://www.python.org/ftp/python/${python_version}/Python-${python_version}.tar.xz
+RUN touch /tmp/aaaaaaaaaa # dummmy change
+RUN tar xf Python-${python_version}.tar.xz
+WORKDIR /Python-${python_version}
+RUN ./configure --prefix /root/python --with-ensurepip=install
+RUN make -j
+RUN mkdir /root/python
+RUN make install
+WORKDIR /
+RUN /root/python/bin/python3 -m pip install virtualenv
+RUN chmod a+rx /root
+ENV PYTHON_VERSION=${python_version}