Skip to content

Commit 49fef6c

Browse files
authored
chore: apply suggestions from code review
1 parent cb84b24 commit 49fef6c

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

IPIP/0379-delegated-ipns-http-api.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,11 @@ Implements are permitted to set a lower limit. If lower than the default maximum
6565
Similarly, a client may check if a server supports ProtocolBuffer formatted records by checking the `X-Ipns-Allow-Protobuf` header key in response to `OPTIONS` request. If present the header value must be either `true` or `false` the absence of the header indicates that ProtocolBuffer formatted records are not supported.
6666

6767
Privacy in delegated IPNS is out of scope for this work.
68-
- The usual JSON parsing rules apply. To prevent potential Denial of Service (DoS) attack, clients should ignore responses larger than 100 providers and introduce a byte size limit that is applicable to their use case.
6968

7069
### Alternatives
7170

7271
See:
73-
- [Libp2p-based IPNS](https://github.com/ipfs/go-ipns).
74-
- Reframe; find out more on [IPIP-337 Design Rationale](0337-delegated-routing-http-api.md#design-rationale).
72+
- Reframe; it was deprecated and now removed. Historical reasons can be found in [IPIP-337 Design Rationale](https://specs.ipfs.tech/ipips/ipip-0337/#design-rationale).
7573

7674
### Copyright
7775

routing/DELEGATED_IPNS_HTTP.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ Where:
7171
cached.
7272
- `PublicKey` represents the optional public key used to sign the record. This field is only
7373
required if it cannot be extracted from the IPNS name, e.g. in the case of legacy RSA keys.
74+
The idea here is that IPNS Record should always have all information neccessary
75+
for signature verification in offline mode, without additional lookups to retrieve the public key.
7476
- `ExtendedData` represents the extensible data as arbitrary JSON object.
7577

7678
## Versioning
@@ -80,7 +82,7 @@ increment the version number.
8082

8183
## API
8284

83-
### `GET /naming/v1/records/{ipns-name}`
85+
### `GET /routing/v1/ipns/{ipns-name}`
8486

8587
**Path Parameters**
8688

@@ -120,7 +122,7 @@ The response body contains the [IPNS record](#ipns-record).
120122
}
121123
```
122124

123-
### `PUT /naming/v1/records/{ipns-name}`
125+
### `PUT /routing/v1/ipns/{ipns-name}`
124126

125127
**Path Parameters**
126128

0 commit comments

Comments
 (0)