-
Notifications
You must be signed in to change notification settings - Fork 53
Expand file tree
/
Copy pathsetup_test.go
More file actions
463 lines (368 loc) · 10.7 KB
/
setup_test.go
File metadata and controls
463 lines (368 loc) · 10.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
package log
import (
"bytes"
"io"
"log/slog"
"os"
"sync"
"testing"
"github.com/stretchr/testify/require"
"go.uber.org/zap"
"go.uber.org/zap/zapcore"
)
func TestGetLoggerDefault(t *testing.T) {
r, w, err := os.Pipe()
require.NoError(t, err, "failed to open pipe")
stderr := os.Stderr
os.Stderr = w
defer func() {
os.Stderr = stderr
}()
// Call SetupLogging again so it picks up stderr change
SetupLogging(Config{Stderr: true})
log := getLogger("test")
log.Error("scooby")
w.Close()
buf := &bytes.Buffer{}
if _, err = io.Copy(buf, r); err != nil {
require.ErrorIs(t, err, io.ErrClosedPipe)
}
require.Contains(t, buf.String(), "scooby")
}
func TestLogToFileAndStderr(t *testing.T) {
// setup stderr
r, w, err := os.Pipe()
require.NoError(t, err, "failed to open pipe")
stderr := os.Stderr
os.Stderr = w
defer func() {
os.Stderr = stderr
}()
// setup file
logfile, err := os.CreateTemp("", "go-log-test")
require.NoError(t, err)
defer os.Remove(logfile.Name())
os.Setenv(envLoggingFile, logfile.Name())
defer os.Unsetenv(envLoggingFile)
// set log output env var
os.Setenv(envLoggingOutput, "file+stderr")
defer os.Unsetenv(envLoggingOutput)
SetupLogging(configFromEnv())
log := getLogger("test")
want := "scooby"
log.Error(want)
w.Close()
buf := &bytes.Buffer{}
if _, err := io.Copy(buf, r); err != nil {
require.ErrorIs(t, err, io.ErrClosedPipe)
}
require.Contains(t, buf.String(), want)
content, err := os.ReadFile(logfile.Name())
require.NoError(t, err)
require.Contains(t, string(content), want)
}
func TestLogToFile(t *testing.T) {
// get tmp log file
logfile, err := os.CreateTemp("", "go-log-test")
require.NoError(t, err)
defer os.Remove(logfile.Name())
// set the go-log file env var
os.Setenv(envLoggingFile, logfile.Name())
defer os.Unsetenv(envLoggingFile)
SetupLogging(configFromEnv())
log := getLogger("test")
// write log to file
want := "grokgrokgrok"
log.Error(want)
// read log file and check contents
content, err := os.ReadFile(logfile.Name())
require.NoError(t, err)
require.Contains(t, string(content), want)
}
func TestLogLabels(t *testing.T) {
r, w, err := os.Pipe()
require.NoError(t, err, "failed to open pipe")
stderr := os.Stderr
os.Stderr = w
defer func() {
os.Stderr = stderr
}()
// set the go-log labels env var
os.Setenv(envLoggingLabels, "dc=sjc-1,foobar") // foobar to ensure we don't panic on bad input.
defer os.Unsetenv(envLoggingLabels)
SetupLogging(configFromEnv())
log := getLogger("test")
log.Error("scooby")
w.Close()
buf := &bytes.Buffer{}
if _, err = io.Copy(buf, r); err != nil {
require.ErrorIs(t, err, io.ErrClosedPipe)
}
t.Log(buf.String())
require.Contains(t, buf.String(), "{\"dc\": \"sjc-1\"}")
}
func TestSubsystemLevels(t *testing.T) {
r, w, err := os.Pipe()
require.NoError(t, err, "failed to open pipe")
stderr := os.Stderr
os.Stderr = w
defer func() {
os.Stderr = stderr
}()
// set the go-log labels env var
os.Setenv(envLogging, "info,test1=debug")
defer os.Unsetenv(envLoggingLabels)
SetupLogging(configFromEnv())
log1 := getLogger("test1")
log2 := getLogger("test2")
log1.Debug("debug1")
log1.Info("info1")
log2.Debug("debug2")
log2.Info("info2")
w.Close()
buf := &bytes.Buffer{}
if _, err = io.Copy(buf, r); err != nil {
require.ErrorIs(t, err, io.ErrClosedPipe)
}
s := buf.String()
require.Contains(t, s, "debug1")
require.NotContains(t, s, "debug2")
require.Contains(t, s, "info1")
require.Contains(t, s, "info2")
}
func TestCustomCore(t *testing.T) {
r1, w1, err := os.Pipe()
require.NoError(t, err, "failed to open pipe")
r2, w2, err := os.Pipe()
require.NoError(t, err, "failed to open pipe")
// logging should work with the custom core
SetPrimaryCore(newCore(PlaintextOutput, w1, LevelDebug))
log := getLogger("test")
log.Error("scooby")
// SetPrimaryCore should replace the core in previously created loggers
SetPrimaryCore(newCore(PlaintextOutput, w2, LevelDebug))
log.Error("doo")
w1.Close()
w2.Close()
buf1 := &bytes.Buffer{}
buf2 := &bytes.Buffer{}
if _, err = io.Copy(buf1, r1); err != nil {
require.ErrorIs(t, err, io.ErrClosedPipe)
}
if _, err = io.Copy(buf2, r2); err != nil {
require.ErrorIs(t, err, io.ErrClosedPipe)
}
require.Contains(t, buf1.String(), "scooby")
require.Contains(t, buf2.String(), "doo")
}
func TestTeeCore(t *testing.T) {
// configure to use a tee logger
tee := zap.New(zapcore.NewTee(
zap.NewNop().Core(),
zap.NewNop().Core(),
), zap.AddCaller())
SetPrimaryCore(tee.Core())
log := getLogger("test")
log.Error("scooby")
// replaces the tee logger with a simple one
SetPrimaryCore(zap.NewNop().Core())
log.Error("doo")
}
func TestLogToStderrAndStdout(t *testing.T) {
r, w, err := os.Pipe()
require.NoError(t, err, "failed to open pipe")
r2, w2, err := os.Pipe()
require.NoError(t, err, "failed to open pipe")
stderr := os.Stderr
stdout := os.Stdout
os.Stderr = w
os.Stdout = w2
defer func() {
os.Stderr = stderr
os.Stdout = stdout
}()
os.Setenv(envLoggingOutput, "stdout+stderr")
defer os.Unsetenv(envLoggingOutput)
SetupLogging(configFromEnv())
log := getLogger("test")
want := "scooby"
log.Error(want)
w.Close()
w2.Close()
buf := &bytes.Buffer{}
if _, err = io.Copy(buf, r); err != nil {
require.ErrorIs(t, err, io.ErrClosedPipe)
}
require.Contains(t, buf.String(), want)
buf.Reset()
if _, err = io.Copy(buf, r2); err != nil {
require.ErrorIs(t, err, io.ErrClosedPipe)
}
require.Contains(t, buf.String(), want)
}
func TestLogToStdoutOnly(t *testing.T) {
r, w, err := os.Pipe()
require.NoError(t, err, "failed to open pipe")
r2, w2, err := os.Pipe()
require.NoError(t, err, "failed to open pipe")
stderr := os.Stderr
stdout := os.Stdout
os.Stderr = w
os.Stdout = w2
defer func() {
os.Stderr = stderr
os.Stdout = stdout
}()
os.Setenv(envLoggingOutput, "stdout")
defer os.Unsetenv(envLoggingOutput)
SetupLogging(configFromEnv())
log := getLogger("test")
want := "scooby"
log.Error(want)
w.Close()
w2.Close()
buf := &bytes.Buffer{}
if _, err := io.Copy(buf, r); err != nil {
require.ErrorIs(t, err, io.ErrClosedPipe)
}
require.Zero(t, buf.Len())
buf.Reset()
if _, err := io.Copy(buf, r2); err != nil {
require.ErrorIs(t, err, io.ErrClosedPipe)
}
require.Contains(t, buf.String(), want)
}
func TestSetLogLevelAutoCreate(t *testing.T) {
// Save and restore original state to avoid test pollution
loggerMutex.Lock()
originalLevels := levels
levels = make(map[string]zap.AtomicLevel)
loggerMutex.Unlock()
defer func() {
loggerMutex.Lock()
levels = originalLevels
loggerMutex.Unlock()
}()
// Set level for non-existent subsystem (should succeed)
err := SetLogLevel("nonexistent", "debug")
require.NoError(t, err)
// Verify level entry was created
loggerMutex.RLock()
atomicLevel, exists := levels["nonexistent"]
loggerMutex.RUnlock()
require.True(t, exists, "level entry should be auto-created")
require.Equal(t, zapcore.DebugLevel, atomicLevel.Level())
// Change level (should update existing entry)
err = SetLogLevel("nonexistent", "error")
require.NoError(t, err)
require.Equal(t, zapcore.ErrorLevel, atomicLevel.Level())
// Invalid level should still fail
err = SetLogLevel("nonexistent", "invalid")
require.Error(t, err)
}
func TestSlogHandler_ReturnsNonNil(t *testing.T) {
// SetupLogging is called in init(), so SlogHandler should return non-nil
handler := SlogHandler()
require.NotNil(t, handler, "SlogHandler should return non-nil handler")
}
func TestSlogHandler_MatchesSlogDefault(t *testing.T) {
// Save original slog.Default for cleanup
originalDefault := slog.Default()
defer slog.SetDefault(originalDefault)
// Enable automatic capture
os.Setenv(envCaptureSlog, "true")
defer os.Unsetenv(envCaptureSlog)
// Setup with capture enabled
SetupLogging(Config{
Format: PlaintextOutput,
Stderr: true,
Level: LevelError,
})
// SlogHandler and slog.Default().Handler() should be the same when capture is enabled
handler := SlogHandler()
defaultHandler := slog.Default().Handler()
require.NotNil(t, handler)
require.NotNil(t, defaultHandler)
// Verify duck-typing marker works
type goLogBridge interface {
GoLogBridge()
}
_, ok := handler.(goLogBridge)
require.True(t, ok, "SlogHandler should implement GoLogBridge marker")
_, ok = defaultHandler.(goLogBridge)
require.True(t, ok, "slog.Default().Handler() should implement GoLogBridge marker when capture is enabled")
}
func TestSlogHandler_WorksWithoutAutomaticCapture(t *testing.T) {
// Save original slog.Default for cleanup
originalDefault := slog.Default()
defer slog.SetDefault(originalDefault)
// Reset slog.Default() to stdlib default before testing
slog.SetDefault(slog.New(slog.NewTextHandler(os.Stderr, nil)))
// Setup with default behavior (automatic capture disabled by default)
SetupLogging(Config{
Format: PlaintextOutput,
Stderr: true,
Level: LevelError,
})
// SlogHandler should still return a valid handler
handler := SlogHandler()
require.NotNil(t, handler, "SlogHandler should work without automatic capture")
// Verify it's go-log's bridge
type goLogBridge interface {
GoLogBridge()
}
_, ok := handler.(goLogBridge)
require.True(t, ok, "SlogHandler should return go-log's bridge")
// But slog.Default() should NOT be go-log's bridge by default (should remain stdlib default)
defaultHandler := slog.Default().Handler()
_, ok = defaultHandler.(goLogBridge)
require.False(t, ok, "slog.Default() should not be go-log's bridge by default")
}
func TestSlogHandler_MultipleSetupLogging(t *testing.T) {
// First setup
SetupLogging(Config{
Format: PlaintextOutput,
Stderr: true,
Level: LevelError,
})
handler1 := SlogHandler()
require.NotNil(t, handler1)
// Second setup with different config
SetupLogging(Config{
Format: JSONOutput,
Stderr: true,
Level: LevelDebug,
})
handler2 := SlogHandler()
require.NotNil(t, handler2)
// Handler should be updated (different instance)
// We can't directly compare handlers, but we can verify both are valid
type goLogBridge interface {
GoLogBridge()
}
_, ok := handler2.(goLogBridge)
require.True(t, ok, "Handler should still be valid after multiple SetupLogging calls")
}
func TestSlogHandler_Concurrent(t *testing.T) {
// Test thread-safety: multiple goroutines calling SlogHandler() concurrently
const goroutines = 100
const iterations = 100
var wg sync.WaitGroup
wg.Add(goroutines)
for i := 0; i < goroutines; i++ {
go func() {
defer wg.Done()
for j := 0; j < iterations; j++ {
handler := SlogHandler()
require.NotNil(t, handler, "SlogHandler should always return non-nil")
// Verify it's a valid handler
type goLogBridge interface {
GoLogBridge()
}
_, ok := handler.(goLogBridge)
require.True(t, ok, "Handler should be valid go-log bridge")
}
}()
}
wg.Wait()
}