Skip to content

Commit 3c279f0

Browse files
committed
Cleaned up the logger
1 parent c73efdb commit 3c279f0

2 files changed

Lines changed: 16 additions & 13 deletions

File tree

src/main/java/io/github/intisy/gradle/github/GithubExtension.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,10 @@
1010
*/
1111
@SuppressWarnings("unused")
1212
public class GithubExtension {
13+
private final ResourcesExtension resources = new ResourcesExtension();
14+
1315
private String accessToken;
1416
private boolean debug;
15-
private final ResourcesExtension resources = new ResourcesExtension();
1617

1718
/**
1819
* @param debug Whether to enable debug logging.

src/main/java/io/github/intisy/gradle/github/Logger.java

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,24 @@
11
package io.github.intisy.gradle.github;
22

33
import org.gradle.api.Project;
4+
import org.gradle.api.logging.LogLevel;
5+
import org.gradle.api.logging.Logging;
46

57
/**
68
* A logger for the GitHub plugin.
79
*/
810
public class Logger {
9-
private static final String PREFIX = "[GitHub] ";
1011
private final GithubExtension extension;
11-
private final org.gradle.api.logging.Logger gradleLogger;
12+
private final org.gradle.api.logging.Logger logger;
13+
private Project project;
1214

1315
/**
1416
* Creates a new logger.
1517
* @param extension The GitHub extension.
1618
*/
1719
public Logger(GithubExtension extension) {
1820
this.extension = extension;
19-
this.gradleLogger = org.gradle.api.logging.Logging.getLogger(Logger.class);
21+
this.logger = Logging.getLogger(Logger.class);
2022
}
2123

2224
/**
@@ -37,23 +39,24 @@ public Logger(GithubExtension extension, Project project) {
3739
throw new NullPointerException("extension and project cannot be null");
3840
}
3941
this.extension = extension;
40-
this.gradleLogger = project.getLogger();
42+
this.logger = project.getLogger();
43+
this.project = project;
4144
}
4245

4346
/**
4447
* Logs a standard lifecycle message, visible in the default Gradle output.
4548
* @param message The message to log.
4649
*/
4750
public void log(String message) {
48-
gradleLogger.lifecycle(PREFIX + message);
51+
logger.lifecycle(message);
4952
}
5053

5154
/**
5255
* Logs an error message.
5356
* @param message The message to log.
5457
*/
5558
public void error(String message) {
56-
gradleLogger.error(PREFIX + message);
59+
logger.error(message);
5760
}
5861

5962
/**
@@ -62,7 +65,7 @@ public void error(String message) {
6265
* @param throwable The exception to log.
6366
*/
6467
public void error(String message, Throwable throwable) {
65-
gradleLogger.error(PREFIX + message, throwable);
68+
logger.error(message, throwable);
6669
}
6770

6871
/**
@@ -74,10 +77,9 @@ public void error(String message, Throwable throwable) {
7477
* @param message The message to log.
7578
*/
7679
public void debug(String message) {
77-
if (extension == null || extension.isDebug()) {
78-
gradleLogger.lifecycle(PREFIX + "[DEBUG] " + message);
79-
} else {
80-
gradleLogger.debug(PREFIX + message);
80+
LogLevel logLevel;
81+
if (extension.isDebug() || project != null && ((logLevel = project.getGradle().getStartParameter().getLogLevel()).equals(LogLevel.INFO) || logLevel.equals(LogLevel.DEBUG))) {
82+
logger.lifecycle(message);
8183
}
8284
}
8385

@@ -86,6 +88,6 @@ public void debug(String message) {
8688
* @param message The message to log.
8789
*/
8890
public void warn(String message) {
89-
gradleLogger.warn(PREFIX + message);
91+
logger.warn(message);
9092
}
9193
}

0 commit comments

Comments
 (0)