Address code review comments

Author: rfsaliev

bindings/cpp/src/svs_runtime_utils.h

@@ -159,9 +159,12 @@ template <typename Alloc>
 Alloc make_allocator(svs::lib::PowerOfTwo blocksize_bytes)
     requires(svs::data::is_blocked_v<Alloc>)
 {
-    assert(
-        blocksize_bytes.raw() > 0 && "Blocked storage types require a non-zero blocksize"
-    );
+    if (blocksize_bytes.raw() == 0) {
+        throw StatusException(
+            ErrorCode::INVALID_ARGUMENT,
+            "Blocked storage types require a non-zero blocksize"
+        );
+    }
     auto parameters = svs::data::BlockingParameters{.blocksize_bytes = blocksize_bytes};
     return Alloc(parameters);
 }
@@ -419,7 +422,9 @@ auto dispatch_storage_kind(StorageKind kind, F&& f, Args&&... args) {
         SVS_DISPATCH_STORAGE_KIND(LeanVec4x8);
         SVS_DISPATCH_STORAGE_KIND(LeanVec8x8);
         default:
-            throw ANNEXCEPTION("not supported SVS storage kind");
+            throw StatusException(
+                ErrorCode::INVALID_ARGUMENT, "Unknown or unsupported SVS storage kind"
+            );
     }
 
 #undef SVS_DISPATCH_STORAGE_KIND

bindings/cpp/src/training_impl.h

@@ -41,21 +41,26 @@ struct LeanVecTrainingDataImpl {
 
     LeanVecTrainingDataImpl(LeanVecMatricesType&& matrices)
         : leanvec_dims_{matrices.view_data_matrix().dimensions()}
-        , leanvec_matrices_{std::move(matrices)} {}
+        , leanvec_matrices_{std::move(matrices)} {
+        if (!svs::detail::lvq_leanvec_enabled()) {
+            throw StatusException(
+                ErrorCode::NOT_IMPLEMENTED, "LeanVec is not supported by CPU."
+            );
+        }
+    }
 
     LeanVecTrainingDataImpl(
         const svs::data::ConstSimpleDataView<float>& data, size_t leanvec_dims
     )
-        : leanvec_dims_{leanvec_dims}
-        , leanvec_matrices_{compute_leanvec_matrices(data, leanvec_dims)} {}
+        : LeanVecTrainingDataImpl(compute_leanvec_matrices(data, leanvec_dims)) {}
 
     LeanVecTrainingDataImpl(
         const svs::data::ConstSimpleDataView<float>& data,
         const svs::data::ConstSimpleDataView<float>& queries,
         size_t leanvec_dims
     )
-        : leanvec_dims_{leanvec_dims}
-        , leanvec_matrices_{compute_leanvec_matrices_ood(data, queries, leanvec_dims)} {}
+        : LeanVecTrainingDataImpl(compute_leanvec_matrices_ood(data, queries, leanvec_dims)
+          ) {}
 
     size_t get_leanvec_dims() const { return leanvec_dims_; }
     const LeanVecMatricesType& get_leanvec_matrices() const { return leanvec_matrices_; }