diff --git a/.github/workflows/pr-validation.yml b/.github/workflows/pr-validation.yml index 935b1d444b..006ef8431f 100644 --- a/.github/workflows/pr-validation.yml +++ b/.github/workflows/pr-validation.yml @@ -22,23 +22,7 @@ jobs: - name: Lint code run: pnpm run lint:changes vitest-tests: - name: Vitest unit tests - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v6 - - uses: pnpm/action-setup@v6 - - uses: actions/setup-node@v6 - with: - node-version: '24' - cache: 'pnpm' - - name: Install dependencies - run: pnpm install --frozen-lockfile - - name: Bootstrap project - run: pnpm run bootstrap - - name: Run vitest unit tests - run: pnpm run test:vitest - vitest-browser-tests: - name: Vitest browser tests + name: Vitest tests runs-on: ubuntu-latest steps: - uses: actions/checkout@v6 @@ -54,23 +38,5 @@ jobs: - name: Bootstrap project run: pnpm run bootstrap - name: Run vitest browser tests - run: pnpm run test:browser - cypress: - name: Cypress component tests - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v6 - - uses: pnpm/action-setup@v6 - - uses: actions/setup-node@v6 - with: - node-version: '24' - cache: 'pnpm' - - name: Install dependencies - run: pnpm install --frozen-lockfile - - name: Install Cypress binary - run: npx cypress install - - name: Bootstrap project - run: pnpm run bootstrap - - name: Run Cypress components tests - run: pnpm run cy:component + run: pnpm run test:vitest diff --git a/CLAUDE.md b/CLAUDE.md index db64e2de1c..9013f8b8a7 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -9,7 +9,6 @@ External docs (preferred over guessing component APIs): https://instructure.desi - `pnpm run bootstrap` — required first time and after `pnpm run clean`. Builds icons, compiles, generates tokens. Plain `pnpm install` is **not** enough. - `pnpm run dev` — docs app at http://localhost:9090 (hot-reloads component changes). - `pnpm run test:vitest ` — run a single package's unit tests, e.g. `pnpm run test:vitest ui-radio-input`. Without an argument it runs everything (slow). -- `pnpm run cy:component` — Cypress component tests. - Visual regression lives in `/regression-test` (separate Next.js app, port 3000). See `/regression-test/README.md`. ## Code conventions diff --git a/cypress/component/AppNav.cy.tsx b/cypress/component/AppNav.cy.tsx deleted file mode 100644 index 3c4e49199d..0000000000 --- a/cypress/component/AppNav.cy.tsx +++ /dev/null @@ -1,70 +0,0 @@ -/* - * The MIT License (MIT) - * - * Copyright (c) 2015 - present Instructure, Inc. - * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to deal - * in the Software without restriction, including without limitation the rights - * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell - * copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in all - * copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, - * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE - * SOFTWARE. - */ - -import { AppNav } from '@instructure/ui/latest' - -import '../support/component' -import 'cypress-real-events' - -describe('', () => { - it('should hide and show items based on the containing element width', () => { - const onUpdate = cy.spy() - const itemWidth = 70 - - const Nav = ({ width }: { width: number }) => ( -
- - coolLabel
} - href="http://instructure.design" - /> - coolLabel} - href="http://instructure.design" - /> - coolLabel} - href="http://instructure.design" - /> - coolLabel} - href="http://instructure.design" - /> -
- - ) - - cy.mount(