Removed duplicated error checking

alexandrevilain · alexellis · commit 5381c4d77377 · 2019-11-01T15:47:38.000Z
Signed-off-by: Alexandre &lt;alexandre.vilain@me.com&gt;
diff --git a/controller.go b/controller.go
@@ -485,9 +485,6 @@ func (c *Controller) syncHandler(key string) error {
 				err = c.updateService(tunnel, host.IP)
 				if err != nil {
 					log.Printf("Error updating service: %s, %s", tunnel.Spec.ServiceName, err.Error())
-				}
-
-				if err != nil {
 					return fmt.Errorf("tunnel update error %s", err)
 				}
 
@@ -514,8 +511,6 @@ func (c *Controller) syncHandler(key string) error {
 					err = c.updateService(tunnel, host.IP)
 					if err != nil {
 						log.Printf("Error updating service: %s, %s", tunnel.Spec.ServiceName, err.Error())
-					}
-					if err != nil {
 						return fmt.Errorf("tunnel update error %s", err)
 					}
 				}
@@ -538,8 +533,6 @@ func (c *Controller) syncHandler(key string) error {
 					err = c.updateService(tunnel, host.IP)
 					if err != nil {
 						log.Printf("Error updating service: %s, %s", tunnel.Spec.ServiceName, err.Error())
-					}
-					if err != nil {
 						return fmt.Errorf("tunnel update error %s", err)
 					}
 				}

Original file line number	Diff line number	Diff line change
`@@ -485,9 +485,6 @@ func (c *Controller) syncHandler(key string) error {`
`485`	`485`	`err = c.updateService(tunnel, host.IP)`
`486`	`486`	`if err != nil {`
`487`	`487`	`log.Printf("Error updating service: %s, %s", tunnel.Spec.ServiceName, err.Error())`
`488`		`- }`
`489`		`-`
`490`		`- if err != nil {`
`491`	`488`	`return fmt.Errorf("tunnel update error %s", err)`
`492`	`489`	`}`
`493`	`490`
`@@ -514,8 +511,6 @@ func (c *Controller) syncHandler(key string) error {`
`514`	`511`	`err = c.updateService(tunnel, host.IP)`
`515`	`512`	`if err != nil {`
`516`	`513`	`log.Printf("Error updating service: %s, %s", tunnel.Spec.ServiceName, err.Error())`
`517`		`- }`
`518`		`- if err != nil {`
`519`	`514`	`return fmt.Errorf("tunnel update error %s", err)`
`520`	`515`	`}`
`521`	`516`	`}`
`@@ -538,8 +533,6 @@ func (c *Controller) syncHandler(key string) error {`
`538`	`533`	`err = c.updateService(tunnel, host.IP)`
`539`	`534`	`if err != nil {`
`540`	`535`	`log.Printf("Error updating service: %s, %s", tunnel.Spec.ServiceName, err.Error())`
`541`		`- }`
`542`		`- if err != nil {`
`543`	`536`	`return fmt.Errorf("tunnel update error %s", err)`
`544`	`537`	`}`
`545`	`538`	`}`