Vibe fixing an issue with logs upon reward redemption

Author: initialxy

server/api/rewards/[id]/approve_redemption.post.ts

@@ -82,7 +82,7 @@ export default defineEventHandler(async (event: H3Event) => {
     user.id,
     reward,
     child.points,
-    child.points + reward.points
+    child.points - reward.points
   )
 
   return {

test/e2e/logs.test.ts

@@ -1,12 +1,15 @@
 import { describe, it, expect, beforeEach } from 'vitest'
 import { setup, $fetch } from '@nuxt/test-utils/e2e'
 import {
-  resetDb,
   createAuthTestData,
+  createTestReward,
+  createTestTask,
   getSessionCookie,
   getUserByUsername,
-  TEST_PARENT_USER,
+  resetDb,
+  setTestUserPoints,
   TEST_CHILD_USER,
+  TEST_PARENT_USER,
 } from '../utils/index'
 import { LogsResponse } from '../../shared/types'
 
@@ -149,6 +152,110 @@ describe('Logs API', async () => {
 
     expect(response).toBeDefined()
     expect(response.logs).toBeDefined()
-    // Logs might be empty, but the structure should be correct
+  })
+
+  it('should correctly log task completions with added points', async () => {
+    // Login as parent to get session cookie
+    const cookie = await getSessionCookie(
+      TEST_PARENT_USER.username,
+      TEST_PARENT_USER.password
+    )
+
+    const parentUser = await getUserByUsername(TEST_PARENT_USER.username)
+    const childUser = await getUserByUsername(TEST_CHILD_USER.username)
+
+    await setTestUserPoints(TEST_CHILD_USER.username, 100)
+
+    const taskId = await createTestTask(
+      parentUser.id,
+      childUser.id,
+      'Test Task',
+      50,
+      'single-use'
+    )
+
+    // Approve the task completion
+    const response = await $fetch(`/api/tasks/${taskId}/approve_complete`, {
+      method: 'POST',
+      headers: {
+        cookie: cookie,
+      },
+    })
+
+    expect(response).toBeDefined()
+    expect((response as any).statusCode).toBe(200)
+
+    const logsResponse = await $fetch<LogsResponse>('/api/logs', {
+      method: 'GET',
+      headers: {
+        cookie: cookie,
+      },
+    })
+
+    expect(logsResponse).toBeDefined()
+    expect(logsResponse.logs).toBeDefined()
+
+    // Find the task completion log entry
+    const completionLog = logsResponse.logs.find(
+      (log) => log.action_type === 'approve_task_complete'
+    )
+
+    expect(completionLog).toBeDefined()
+    expect(completionLog?.points_before).toBe(100)
+    expect(completionLog?.points_after).toBe(150)
+  })
+
+  it('should correctly log reward redemptions with deducted points', async () => {
+    // Login as parent to get session cookie
+    const cookie = await getSessionCookie(
+      TEST_PARENT_USER.username,
+      TEST_PARENT_USER.password
+    )
+
+    const parentUser = await getUserByUsername(TEST_PARENT_USER.username)
+    const childUser = await getUserByUsername(TEST_CHILD_USER.username)
+
+    await setTestUserPoints(TEST_CHILD_USER.username, 100)
+
+    const rewardId = await createTestReward(
+      parentUser.id,
+      childUser.id,
+      'Test Reward',
+      50,
+      'single-use'
+    )
+
+    // Approve the redemption
+    const response = await $fetch(
+      `/api/rewards/${rewardId}/approve_redemption`,
+      {
+        method: 'POST',
+        headers: {
+          cookie: cookie,
+        },
+      }
+    )
+
+    expect(response).toBeDefined()
+    expect((response as any).statusCode).toBe(200)
+
+    const logsResponse = await $fetch<LogsResponse>('/api/logs', {
+      method: 'GET',
+      headers: {
+        cookie: cookie,
+      },
+    })
+
+    expect(logsResponse).toBeDefined()
+    expect(logsResponse.logs).toBeDefined()
+
+    // Find the reward redemption log entry
+    const redemptionLog = logsResponse.logs.find(
+      (log) => log.action_type === 'approve_redemption'
+    )
+
+    expect(redemptionLog).toBeDefined()
+    expect(redemptionLog?.points_before).toBe(100)
+    expect(redemptionLog?.points_after).toBe(50)
   })
 })