Split users' name to first_name and last_name

Author: user890104

app/controllers/application_controller.rb

@@ -31,9 +31,9 @@ def set_locale
   end
 
   def configure_permitted_parameters
-    devise_parameter_sanitizer.permit(:sign_up, keys: [:name, :username, :email])
+    devise_parameter_sanitizer.permit(:sign_up, keys: [:first_name, :last_name, :username, :email])
     devise_parameter_sanitizer.permit(:sign_in, keys: [:username])
-    devise_parameter_sanitizer.permit(:account_update, keys: [:name, :username,
+    devise_parameter_sanitizer.permit(:account_update, keys: [:first_name, :last_name, :username,
       :email, :url, :locale,
       :twitter, :announce_my_presence,
       :github, :jabber,

app/models/user.rb

@@ -16,7 +16,6 @@ class User < ApplicationRecord
   validates :username, uniqueness: {case_sensitive: false}, presence: true
   validates :twitter, format: {with: /\A[A-Za-z0-9_]{1,15}\z/}, allow_blank: true
   validates :url, format: {with: /\A(http|https):\/\/[a-z0-9]+([-.]{1}[a-z0-9]+)*\.[a-z-]{2,63}(:[0-9]{1,5})?(\/.*)?\z/ix}, allow_blank: true
-  validates :name, presence: true
   validates :first_name, presence: true
   validates :last_name, presence: true
   validates :github, format: {with: /\A[a-z0-9][a-z0-9-]{,38}\z/i}, allow_blank: true
@@ -41,6 +40,10 @@ def email_md5
     Digest::MD5.hexdigest email
   end
 
+  def name
+    [first_name, last_name].compact.join(" ").strip
+  end
+
   def twitter=(handle)
     write_attribute :twitter, handle.gsub(/\A@/, "") if handle
   end

app/views/devise/registrations/edit.html.slim

@@ -17,7 +17,8 @@ section.container
                 | Avatar by
                 =< link_to 'Gravatar', 'https://gravatar.com'
 
-          = f.input :name, required: true
+          = f.input :first_name, required: true
+          = f.input :last_name, required: true
           = f.input :username, required: true
           = f.input :email, required: true
           = f.input :locale, collection: I18n.available_locales, required: true

app/views/devise/registrations/new.html.slim

@@ -9,7 +9,8 @@ section.container
         = f.error_notification
         .form-inputs
           = f.input :username, required: true, autofocus: true
-          = f.input :name, required: true, autofocus: true
+          = f.input :first_name, required: true, autofocus: true
+          = f.input :last_name, required: true, autofocus: true
           = f.input :email, required: true, autofocus: true
           = f.input :password, required: true, hint: (t("views.registrations.minimum_characters", minimum: @minimum_password_length) if @validatable)
           = f.input :password_confirmation, required: true

bin/setup

@@ -29,8 +29,12 @@ OptionParser.new do |opts|
     options[:username] = username
   end
 
-  opts.on('-n', '--name NAME', 'Name') do |name|
-    options[:name] = name
+  opts.on('-f', '--firstname FIRST_NAME', 'First name') do |first_name|
+    options[:first_name] = first_name
+  end
+
+  opts.on('-l', '--lastname LAST_NAME', 'Last name') do |last_name|
+    options[:last_name] = last_name
   end
 
   opts.on('-p', '--password PASSWORD', 'Password') do |password|
@@ -93,7 +97,8 @@ Dir.chdir APP_ROOT do
         print "\npassword confirmation: "
         password_confirmation = STDIN.noecho(&:gets)
       end
-      options[:name] = prompt "\nname: " unless options[:name]
+      options[:first_name] = prompt "\nfirst name: " unless options[:first_name]
+      options[:last_name] = prompt "\nlast name: " unless options[:last_name]
     end
 
     puts "Loading the rails environment."

config/locales/bg.yml

@@ -41,6 +41,8 @@ bg:
     attributes:
       user:
         name: Име
+        first_name: Собствено име
+        last_name: Фамилия
         url: Сайт
         twitter: X
         username: Потребителско име

config/locales/en.yml

@@ -35,6 +35,8 @@ en:
     attributes:
       user:
         name: Name
+        first_name: First name
+        last_name: Last name
         url: Site
         twitter: X
         username: Username

db/schema.rb

@@ -146,7 +146,8 @@
     t.datetime "last_sign_in_at", precision: nil
     t.string "current_sign_in_ip"
     t.string "last_sign_in_ip"
-    t.string "name"
+    t.string "first_name"
+    t.string "last_name"
     t.string "url"
     t.string "twitter"
     t.boolean "announce_my_presence", default: false, null: false

spec/factories/users.rb

@@ -2,7 +2,8 @@
 
 FactoryBot.define do
   factory :user, aliases: [:owner] do
-    name { Faker::Name.name }
+    first_name { Faker::Name.name }
+    last_name { Faker::Name.name }
     sequence(:username) { |u| "username#{u}" }
     email { Faker::Internet.email }
     locale { I18n.available_locales.first.to_s }
@@ -25,7 +26,8 @@
   end
 
   factory :registration, class: User do
-    name { Faker::Name.name }
+    first_name { Faker::Name.name }
+    last_name { Faker::Name.name }
     sequence(:username) { |u| "username#{u}" }
     email { |u| Faker::Internet.email(u.username) }
     password { Faker::Internet.password }

spec/models/user_spec.rb

@@ -13,9 +13,15 @@
     expect(build(:user)).to be_a Devise::Models::Lockable
   end
 
-  describe "name" do
+  describe "first_name" do
     it "must be present" do
-      expect(build(:user, name: nil)).to have_error_on :name
+      expect(build(:user, first_name: nil)).to have_error_on :first_name
+    end
+  end
+
+  describe "last_name" do
+    it "must be present" do
+      expect(build(:user, last_name: nil)).to have_error_on :last_name
     end
   end