Skip to content

Commit 15471d6

Browse files
authored
Merge pull request #135 from imcf/gha-markdownlint
Add a job to the linting workflow running the [markdownlint-cli2-action][1]. While at it: - rule out `markdownlint`'s complaints - apply a few spelling fixes - extend the spelling dictionary [1]: https://github.com/marketplace/actions/markdownlint-cli2-action
2 parents 266edae + 7cb7b68 commit 15471d6

4 files changed

Lines changed: 47 additions & 7 deletions

File tree

β€Ž.github/workflows/lint.ymlβ€Ž

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,36 @@
1-
name: Code Linting πŸ”Žβš‘
1+
name: Linting πŸ“‘πŸ”Žβš‘
22

33
on:
44
push:
55
pull_request:
66
workflow_dispatch:
77

88
jobs:
9-
10-
lint:
9+
ruff:
1110
name: Ruff βš‘πŸ•΅
1211

1312
runs-on: ubuntu-latest
1413

1514
steps:
16-
1715
- name: πŸ“₯ Checkout repo
1816
uses: actions/checkout@v4
1917

2018
- name: Run Ruff checks ⚑
2119
uses: astral-sh/ruff-action@v3
2220
with:
2321
args: check
22+
23+
markdownlint:
24+
name: Markdownlint πŸ“‘πŸ•΅
25+
26+
runs-on: ubuntu-latest
27+
steps:
28+
- name: πŸ“₯ Checkout repo
29+
uses: actions/checkout@v4
30+
31+
- name: Run markdownlint-cli2-action πŸ“‘
32+
uses: DavidAnson/markdownlint-cli2-action@v22
33+
with:
34+
globs: |
35+
*.md
36+
!test/*.md

β€Ž.vscode/settings.jsonβ€Ž

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,31 +15,56 @@
1515
"bdvp",
1616
"bigstitcher",
1717
"biop",
18+
"clij",
19+
"Dscijava",
20+
"flatfield",
21+
"Fluo",
22+
"IJPB",
1823
"imageplus",
24+
"imarisconvert",
1925
"imglib",
26+
"imgplus",
2027
"interestpoint",
2128
"intermodes",
2229
"javax",
30+
"keyvalue",
2331
"Kheops",
32+
"labelimage",
33+
"listdir",
2434
"micrometa",
35+
"Morpholib",
2536
"multiresolution",
37+
"olefile",
38+
"omerotools",
39+
"ordereddict",
2640
"otsu",
2741
"pathtools",
42+
"phmax",
2843
"Prefs",
44+
"processingoptions",
2945
"PTBIOP",
3046
"PYENV",
3147
"pylint",
3248
"ransac",
3349
"renyi",
3450
"repartitions",
51+
"resultstable",
3552
"RETVAL",
53+
"roimanager",
54+
"rois",
55+
"rollingball",
3656
"scijava",
3757
"shanbhag",
3858
"sjlogging",
59+
"smtpserver",
3960
"spimdata",
61+
"stardist",
62+
"stdv",
4063
"strtools",
4164
"subfolders",
4265
"subsampling",
66+
"TESTDATA",
67+
"thresholding",
4368
"trackmate",
4469
"virtualenv",
4570
"virtualfish"

β€ŽDESC.mdβ€Ž

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
1+
<!-- markdownlint-disable MD041 (first-line-heading) -->
2+
13
:snake::coffee::nut_and_bolt::wrench:
24
A collection of commonly used Python helper functions.

β€ŽTESTING.mdβ€Ž

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ Those parts of the package that do not interact / depend on ImageJ objects can
66
be tested via [`pytest`][pytest] up to a certain level, some (most?) of them
77
should even work in a Python 3 environment.
88

9-
To perform those tests, the packges otherwise provided by ImageJ need to be
10-
mocked using the `imcf-fiji-mocks` package. For seting up a *venv* use the steps
11-
described here:
9+
To perform those tests, the packages otherwise provided by ImageJ need to be
10+
mocked using the `imcf-fiji-mocks` package. For setting up a *venv* use the
11+
steps described here:
1212

1313
```bash
1414
# check if we're "inside" the repo already, otherwise clone it here:

0 commit comments

Comments
Β (0)