From 194c1a356e8243241d4962040ed78f7c7789bc32 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9sar=20Rom=C3=A1n?= Date: Tue, 20 Jan 2026 21:12:58 +0000 Subject: [PATCH] refactor(ia): fix type errors detected with ty --- src/com/inductiveautomation/ignition/common/opc/__init__.py | 4 ++-- .../ignition/common/script/abc/__init__.py | 2 +- .../ignition/common/tags/paths/__init__.py | 4 ---- .../ignition/common/script/abc/__init__.pyi | 2 +- .../ignition/common/tags/paths/__init__.pyi | 1 - 5 files changed, 4 insertions(+), 9 deletions(-) diff --git a/src/com/inductiveautomation/ignition/common/opc/__init__.py b/src/com/inductiveautomation/ignition/common/opc/__init__.py index d37df06..ad13318 100644 --- a/src/com/inductiveautomation/ignition/common/opc/__init__.py +++ b/src/com/inductiveautomation/ignition/common/opc/__init__.py @@ -182,11 +182,11 @@ def getItemType(self): def getProperties(self): # type: () -> List[BrowseElement.PropertyElement] - return self._properties.values() + pass def getProperty(self, id_): # type: (int) -> BrowseElement.PropertyElement - return self._properties[id_] + pass def getServer(self): # type: () -> Union[str, unicode] diff --git a/src/com/inductiveautomation/ignition/common/script/abc/__init__.py b/src/com/inductiveautomation/ignition/common/script/abc/__init__.py index 7f65713..6637a10 100644 --- a/src/com/inductiveautomation/ignition/common/script/abc/__init__.py +++ b/src/com/inductiveautomation/ignition/common/script/abc/__init__.py @@ -246,7 +246,7 @@ def update(self, *args, **kwargs): # type: (*PyObject, **Union[str, unicode]) -> None raise NotImplementedError - def __setitem__(self, pyKey, value): + def __setitem__(self, pyKey, pyValue): # type: (PyObject, PyObject) -> None raise NotImplementedError diff --git a/src/com/inductiveautomation/ignition/common/tags/paths/__init__.py b/src/com/inductiveautomation/ignition/common/tags/paths/__init__.py index 66d62b8..a4f0734 100644 --- a/src/com/inductiveautomation/ignition/common/tags/paths/__init__.py +++ b/src/com/inductiveautomation/ignition/common/tags/paths/__init__.py @@ -16,10 +16,6 @@ class AbstractTagPath(Object, TagPath): - def __init__(self): - # type: () -> None - super(AbstractTagPath, self).__init__() - @staticmethod def compareNullLow(c1, c2): # type: (Property, Property) -> int diff --git a/stubs/stubs/com/inductiveautomation/ignition/common/script/abc/__init__.pyi b/stubs/stubs/com/inductiveautomation/ignition/common/script/abc/__init__.pyi index 8608989..6f2ae43 100644 --- a/stubs/stubs/com/inductiveautomation/ignition/common/script/abc/__init__.pyi +++ b/stubs/stubs/com/inductiveautomation/ignition/common/script/abc/__init__.pyi @@ -76,7 +76,7 @@ class AbstractMutableJythonMap(MutableJythonMap): self, pyKey: PyObject, def_: Optional[PyObject] = ... ) -> PyObject: ... def update(self, *args: PyObject, **kwargs: Union[str, unicode]) -> None: ... - def __setitem__(self, pyKey: PyObject, value: PyObject) -> None: ... + def __setitem__(self, pyKey: PyObject, pyValue: PyObject) -> None: ... def __delitem__(self, pyKey: PyObject) -> None: ... class AbstractMutableJythonSequence(AbstractJythonSequence, MutableJythonSequence): diff --git a/stubs/stubs/com/inductiveautomation/ignition/common/tags/paths/__init__.pyi b/stubs/stubs/com/inductiveautomation/ignition/common/tags/paths/__init__.pyi index c40ab33..1a22f95 100644 --- a/stubs/stubs/com/inductiveautomation/ignition/common/tags/paths/__init__.pyi +++ b/stubs/stubs/com/inductiveautomation/ignition/common/tags/paths/__init__.pyi @@ -5,7 +5,6 @@ from com.inductiveautomation.ignition.common.tags.model import TagPath from java.lang import Object class AbstractTagPath(Object, TagPath): - def __init__(self) -> None: ... @staticmethod def compareNullLow(c1: Property, c2: Property) -> int: ... def getChildPath(self, nextId: Union[str, unicode]) -> TagPath: ...