XML files are almost unreadable in dark mode

[SylwesterZarebski]

Steps to reproduce

1. Open ILSpy.
2. Set dark mode.
3. Open any library with XML files in embedded resources.
4. View XML file.

Error message shown

Details

• Product in use: ILSpy
• Version in use: 11.0.0.9375

[christophwille]

Is that Windows 10 by any chance?

Edit: For comparison, Windows 11 with resource from ILSpy itself:

[SylwesterZarebski]

Unfortunately no, Windows 11 here. Only changed options is mode and font to Source Code Pro.
Also other things, like highlighting some buttons or rows are the same as light theme.
Here is highlighted left Decompiler tab button:

I've just reset Display options and set mode plus font to no avail.

[christophwille]

That "highlighting box" (where the Decompiler options are), that one I see as well (text unreadable just like in your screenshot).

Interestingly when I changed the font size to 16, the decompiled text view did change the color closer to your screenshot - and from then on, it stays that way. Even when I delete ilspy.xml. Most curious.

Edit: Switching to Light and then Dark restores the colors I sent in the first screenshot.

[christophwille]

I know this is slightly strange - could you please try builds for PR #3987? Those would be at https://github.com/icsharpcode/ILSpy/actions/workflows/build-ilspy.yml?query=branch%3Awin-a11y-textsize I was able to repro the "decolorization/flattening of colors" with master but no longer with builds from that branch and I'd like to know if that is coincidence on my machine.

[christophwille]

Maybe I am finally onto the root cause; once the latest build completes, please grab the bits. Build: https://github.com/icsharpcode/ILSpy/actions?query=workflow%3A%22Build+ILSpy%22+branch%3Atheme-colorizer-hardening

[christophwille]

The change has been merged to master - please get the bits and report back whether we successfully fixed the problem. Thanks.

[SylwesterZarebski]

Thanks, it looks much better, but some attributes are still too dark - look at xmlns:

one more example:

[christophwille]

So we can close the bug, but maybe need to open an enhancement request for the dark color scheme in general. I'd propose the following: you keep collecting colors that you consider "off" (hard on the eye), and then open an enhancement issue?

[SylwesterZarebski]

As enhancement You mean feature request or bug issue?
Maybe it would be better to create meta issue to collect all dark mode inconsistencies (two, for now, this and tooltip one)?

[SylwesterZarebski]

PS. Another example of incorrect link colour - on about page:

[christophwille]

I can relabel the standard ones (I was thinking of label Enhancement). We should distinguish between highlighting bugs and general UI dark mode bugs.