Integrate render command with an active cluster

Author: renovate[bot]

README.md

@@ -254,9 +254,9 @@ The BaseComposite also provides access to the following Crossplane Function leve
 | self.environment | Map | The response environment, initialized from the request context environment |
 | self.requireds | Requireds | Request and read additional local Kubernetes resources |
 | self.resources | Resources | Define and process composed resources |
-| self.unknownsFatal | Boolean | Terminate the composition if already created resources are assigned unknown values, default True |
 | self.usages| Boolean | Generate Crossplane Usages for resource dependencies, default False |
 | self.autoReady | Boolean | Perform auto ready processing on all composed resources, default True |
+| self.unknownsFatal | Boolean | Terminate the composition if already created resources are assigned unknown values, default False |
 
 ### Composed Resources
 
@@ -281,9 +281,9 @@ Resource class:
 | Resource.conditions | Conditions | The resource conditions |
 | Resource.connection | Map | The resource observed connection details |
 | Resource.ready | Boolean | The resource ready state |
-| Resource.unknownsFatal | Boolean | Terminate the composition if this resource has been created and is assigned unknown values, default is Composite.unknownsFatal |
 | Resource.usages | Boolean | Generate Crossplane Usages for this resource, default is Composite.autoReady |
 | Resource.autoReady | Boolean | Perform auto ready processing on this resource, default is Composite.autoReady |
+| Resource.unknownsFatal | Boolean | Terminate the composition if this resource has been created and is assigned unknown values, default is Composite.unknownsFatal |
 
 ### Required Resources
 

crossplane/pythonic/composite.py

@@ -111,9 +111,9 @@ def __init__(self, crossplane_v1, request, single_use, logger):
         self.environment = self.context['apiextensions.crossplane.io/environment']
         self.requireds = Requireds(self)
         self.resources = Resources(self)
-        self.unknownsFatal = True
         self.autoReady = True
         self.usages = False
+        self.unknownsFatal = False
 
         observed = self.request.observed.composite
         desired = self.response.desired.composite
@@ -238,16 +238,28 @@ def __init__(self, composite, name):
         self.desired = desired.resource
         self.conditions = Conditions(observed)
         self.connection = observed.connection_details
-        self.unknownsFatal = None
+        if self.desired._parent.ready == fnv1.Ready.READY_TRUE:
+            self._ready =  True
+        elif self.desired._parent.ready == fnv1.Ready.READY_FALSE:
+            self._ready = False
+        else:
+            self._ready = None
         self.autoReady = None
         self.usages = None
+        self.unknownsFatal = None
 
-    def __call__(self, apiVersion=_notset, kind=_notset, namespace=_notset, name=_notset):
+    def __call__(self, kind=_notset, apiVersion=_notset, namespace=_notset, name=_notset):
         self.desired()
+        if kind != _notset:
+            # Allow for apiVersion in the first arg and kind in the second arg
+            if '/' in kind or kind == 'v1':
+                if apiVersion != _notset:
+                    self.kind = apiVersion
+                apiVersion = kind
+            else:
+                self.kind = kind
         if apiVersion != _notset:
             self.apiVersion = apiVersion
-        if kind != _notset:
-            self.kind = kind
         if namespace != _notset:
             self.metadata.namespace = namespace
         if name != _notset:
@@ -296,6 +308,7 @@ def spec(self):
     def spec(self, spec):
         self.desired.spec = spec
 
+    # Used by Secret:v1
     @property
     def type(self):
         return self.desired.type
@@ -318,22 +331,17 @@ def status(self):
 
     @property
     def ready(self):
-        ready = self.desired._parent.ready
-        if ready == fnv1.Ready.READY_TRUE:
-            return True
-        if ready == fnv1.Ready.READY_FALSE:
-            return False
-        return None
+        return self._ready
 
     @ready.setter
     def ready(self, ready):
-        if ready:
-            ready = fnv1.Ready.READY_TRUE
-        elif ready == None or (isinstance(ready, protobuf.Value) and ready._isUnknown):
-            ready = fnv1.Ready.READY_UNSPECIFIED
+        self._ready = ready
+        if ready is None:
+            self.desired._parent.ready = fnv1.Ready.READY_UNSPECIFIED
+        elif ready:
+            self.desired._parent.ready = fnv1.Ready.READY_TRUE
         else:
-            ready = fnv1.Ready.READY_FALSE
-        self.desired._parent.ready = ready
+            self.desired._parent.ready = fnv1.Ready.READY_FALSE
 
 
 class Requireds:
@@ -408,12 +416,18 @@ def __init__(self, composite, name):
             self._resources = composite.request.required_resources[name]
         self._cache = {}
 
-    def __call__(self, apiVersion=_notset, kind=_notset, namespace=_notset, name=_notset, labels=_notset):
+    def __call__(self, kind=_notset, apiVersion=_notset, namespace=_notset, name=_notset, labels=_notset):
         self._selector()
+        if kind != _notset:
+            # Allow for apiVersion in the first arg and kind in the second arg
+            if '/' in kind or kind == 'v1':
+                if apiVersion != _notset:
+                    self.kind = apiVersion
+                apiVersion = kind
+            else:
+                self.kind = kind
         if apiVersion != _notset:
             self.apiVersion = apiVersion
-        if kind != _notset:
-            self.kind = kind
         if namespace != _notset:
             self.namespace = namespace
         if name != _notset:
@@ -802,60 +816,36 @@ def _resource_name(self):
 
     @property
     def observed(self):
-        if self._composite.crossplane_v1:
-            return self._composite.response.observed.composite.connection_details
-        data = protobuf.Map()
-        for key, value in self._composite.resources[self._resource_name].observed.data:
-            data[key] = protobuf.B64Decode(value)        
-        return data
+        return self._composite.response.observed.composite.connection_details
 
     def __getattr__(self, key):
         return self[key]
 
     def __getitem__(self, key):
-        if self._composite.crossplane_v1:
-            return self._composite.response.desired.composite.connection_details[key]
-        value = self._composite.resources[self._resource_name].data[key]
-        if value:
-            value = protobuf.B64Decode(value)
-        return value
+        return self._composite.response.desired.composite.connection_details[key]
 
     def __bool__(self):
-        if self._composite.crossplane_v1:
-            return bool(self._composite.response.desired.composite.connection_details)
-        return bool(self._composite.resources[self._resource_name].data)
+        return bool(self._composite.response.desired.composite.connection_details)
 
     def __len__(self):
-        if self._composite.crossplane_v1:
-            return len(self._composite.response.desired.composite.connection_details)
-        return len(self._composite.resources[self._resource_name].data)
+        return len(self._composite.response.desired.composite.connection_details)
 
     def __contains__(self, key):
-        if self._composite.crossplane_v1:
-            return key in self._composite.response.desired.composite.connection_details
+        return key in self._composite.response.desired.composite.connection_details
 
     def __iter__(self):
-        keys = set()
-        if self._composite.crossplane_v1:
-            for key, value in self._composite.response.desired.composite.connection_details:
-                yield key, value
-        for key, value in self._composite.resources[self._resource_name].data:
-            yield key, protobuf.B64Decode(value)
+        for key, value in self._composite.response.desired.composite.connection_details:
+            yield key, value
 
     def __str__(self):
         return format(self)
 
     def __format__(self, spec='yaml'):
-        if self._composite.crossplane_v1:
-            return format(self._composite.response.desired.composite.connection_details, spec)
-        data = protobuf.Map()
-        for key, value in self._composite.resources[self._resource_name].data:
-            data[key] = protobuf.B64Decode(value)
-        return format(data, spec)
+        return format(self._composite.response.desired.composite.connection_details, spec)
 
     def __call__(self, **kwargs):
+        self._composite.response.desired.composite.connection_details(**kwargs)
         if self._composite_v1:
-            self._composite.response.desired.composite.connection_details(**kwargs)
             return
         del self._composite.resources[self._resource_name]
         for key, value in kwargs:
@@ -872,16 +862,13 @@ def __setitem__(self, key, value):
                 if not value:
                     return
             value = str(value)
-        if self._composite.crossplane_v1:
-            self._composite.response.desired.composite.connection_details[key] = value
+        self._composite.response.desired.composite.connection_details[key] = value
+        if self._composite.crossplane_v1 or not self._composite.connectionSecret.name:
             return
-        #if not self._composite.connectionSecret.name:
-        #    return
         if self._resource_name in self._composite.resources:
             secret = self._composite.resources[self._resource_name]
         else:
             secret = self._composite.resources[self._resource_name]('v1', 'Secret')
-            print(bool(self._composite.connectionSecret.name), len(self._composite.connectionSecret.name))
             if self._composite.connectionSecret.name and len(self._composite.connectionSecret.name):
                 secret.metadata.name = self._composite.connectionSecret.name
             if not self._composite.metadata.namespace:
@@ -896,8 +883,8 @@ def __delattr__(self, key):
         del self[key]
 
     def __delitem__(self, key):
+        del self._composite.response.desired.composite.connection_details[key]
         if self._composite.crossplane_v1:
-            del self._composite.response.desired.composite.connection_details[key]
             return
         if self._resource_name in self._composite.resources:
             del self._composite.resources[self._resource_name].data[key]

crossplane/pythonic/protobuf.py

@@ -37,21 +37,29 @@ def Unknown():
 
 def Yaml(string, readOnly=None):
     if isinstance(string, (FieldMessage, Value)):
+        if not string:
+            return string
         string = str(string)
     return Value(None, None, yaml.safe_load(string), readOnly)
 
 def Json(string, readOnly=None):
     if isinstance(string, (FieldMessage, Value)):
+        if not string:
+            return string
         string = str(string)
     return Value(None, None, json.loads(string), readOnly)
 
 def B64Encode(string):
     if isinstance(string, (FieldMessage, Value)):
+        if not string:
+            return string
         string = str(string)
     return base64.b64encode(string.encode('utf-8')).decode('utf-8')
 
 def B64Decode(string):
     if isinstance(string, (FieldMessage, Value)):
+        if not string:
+            return string
         string = str(string)
     return base64.b64decode(string.encode('utf-8')).decode('utf-8')
 
@@ -684,10 +692,11 @@ def __getattr__(self, key):
 
     def __getitem__(self, key):
         key = self._validate_key(key)
-        if key in self._cache:
-            return self._cache[key]
-        if key in self._unknowns:
-            return self._unknowns[key]
+        if key != append:
+            if key in self._cache:
+                return self._cache[key]
+            if key in self._unknowns:
+                return self._unknowns[key]
         if isinstance(key, str):
             match self._kind:
                 case 'struct_value':
@@ -701,14 +710,26 @@ def __getitem__(self, key):
         elif isinstance(key, int):
             match self._kind:
                 case 'list_value':
+                    if key < 0:
+                        key = len(self._value.list_value.values) + key
+                        if key < 0:
+                            key = 0
                     if key < len(self._value.list_value.values):
                         value = self._value.list_value.values[key]
                     else:
+                        if key == append:
+                            key = len(self._value.list_value.values)
                         value = _Unknown
                 case 'ListValue':
+                    if key < 0:
+                        key = len(self._value.values) + key
+                        if key < 0:
+                            key = 0
                     if key < len(self._value.values):
                         value = self._value.values[key]
                     else:
+                        if key == append:
+                            key = len(self._value.values)
                         value = _Unknown
                 case 'Unknown':
                     value = _Unknown