Skip to content

Commit 2ca25ad

Browse files
author
Kishan Sairam Adapa
authored
fix: bug in proactive rescheduling not accounting for future timeout (#434)
1 parent 3939ffc commit 2ca25ad

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

raw-spans-grouper/raw-spans-grouper/src/main/java/org/hypertrace/core/rawspansgrouper/RawSpansProcessor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,12 +175,12 @@ public void process(Record<TraceIdentity, RawSpan> record) {
175175
traceEmitPunctuator.scheduleTask(currentTimeMs, key);
176176
} else {
177177
traceState.getSpanIds().add(spanId);
178-
long prevScheduleTimestamp = traceState.getTraceEndTimestamp();
178+
long prevScheduleTimestamp = traceState.getTraceEndTimestamp() + groupingWindowTimeoutMs;
179179
traceState.setTraceEndTimestamp(currentTimeMs);
180180
if (!traceEmitPunctuator.rescheduleTask(
181181
prevScheduleTimestamp, currentTimeMs + groupingWindowTimeoutMs, key)) {
182182
logger.debug(
183-
"Failed to reschedule task on getting span for trace key {}, schedule already dropped!",
183+
"Failed to proactively reschedule task on getting span for trace key {}, schedule already dropped!",
184184
key);
185185
}
186186
}

0 commit comments

Comments
 (0)