fix type issues

Author: AlePouroullis

src/humanloop/files/client.py

@@ -118,8 +118,7 @@ def list_files(
     def retrieve_by_path(
         self,
         *,
-        # @TODO: @ale, can this be None?
-        path: str | None = None,
+        path: str,
         environment: typing.Optional[str] = None,
         include_raw_file_content: typing.Optional[bool] = None,
         request_options: typing.Optional[RequestOptions] = None,

src/humanloop/overload.py

@@ -75,7 +75,7 @@ def _handle_tracing_context(kwargs: Dict[str, Any], client: Any) -> Dict[str, An
         if "trace_parent_id" in kwargs:
             logger.warning(
                 "Ignoring trace_parent_id argument at line %d: the Flow decorator manages tracing.",
-                inspect.currentframe().f_lineno,  # type: ignore [union-attr]
+                inspect.currentframe().f_lineno,  # type: ignore[union-attr]
             )
         kwargs = {
             **kwargs,
@@ -120,7 +120,7 @@ def _handle_local_files(
         return kwargs
 
     try:
-        file_content = sync_client.get_file_content(normalized_path, file_type)  # type: ignore [arg-type] file_type was checked above
+        file_content = sync_client.get_file_content(normalized_path, file_type)  # type: ignore [arg-type]
         kwargs[file_type] = file_content
     except HumanloopRuntimeError as e:
         raise HumanloopRuntimeError(f"Failed to use local file for `{normalized_path}`: {str(e)}")
@@ -191,7 +191,7 @@ def overload_client(
     """Overloads client methods to add tracing, local file handling, and evaluation context."""
     # Store original log method as _log for all clients. Used in flow decorator
     if hasattr(client, "log") and not hasattr(client, "_log"):
-        client._log = client.log  # type: ignore [attr-defined]
+        client._log = client.log  # type: ignore[attr-defined]
 
         # Create a closure to capture sync_client and use_local_files
         def log_wrapper(self: Any, **kwargs) -> LogResponseType:
@@ -205,7 +205,7 @@ def log_wrapper(self: Any, **kwargs) -> LogResponseType:
             logger.error("sync_client is None but client has call method and use_local_files=%s", use_local_files)
             raise HumanloopRuntimeError("sync_client is required for clients that support call operations")
         if hasattr(client, "call") and not hasattr(client, "_call"):
-            client._call = client.call  # type: ignore [attr-defined]
+            client._call = client.call  # type: ignore[attr-defined]
 
             # Create a closure to capture sync_client and use_local_files
             def call_wrapper(self: Any, **kwargs) -> CallResponseType:

src/humanloop/sync/sync_client.py

@@ -343,7 +343,7 @@ def pull(self, path: str | None = None, environment: str | None = None) -> Tuple
         )
 
         try:
-            if path is None:
+            if normalized_path is None or path is None: # path being None means normalized_path is None, but we check both for improved type safety
                 # Pull all files from the root
                 logger.debug("Pulling all files from root")
                 successful_files, failed_files = self._pull_directory(