Skip to content

Commit 099ae1d

Browse files
jamesbaskervilleAndrei Bratu
authored andcommitted
Don't query if no local evaluators; cleanup error printing
1 parent 2fb9086 commit 099ae1d

File tree

1 file changed

+16
-29
lines changed
  • src/humanloop/eval_utils

1 file changed

+16
-29
lines changed

src/humanloop/eval_utils/run.py

Lines changed: 16 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -204,10 +204,7 @@ def _overload_log(
204204
response = self._log(**kwargs)
205205
except Exception as e:
206206
error_message = str(e).replace("\n", " ")
207-
if len(error_message) > 100:
208-
sys.stderr.write(f"{RED}Failed to log: {error_message[:100]}...{RESET}\n")
209-
else:
210-
sys.stderr.write(f"{RED}Failed to log: {error_message}{RESET}\n")
207+
sys.stderr.write(f"{RED}Failed to log: {error_message[:100]}...{RESET}\n")
211208
raise e
212209

213210
# Notify the run_eval utility about one Log being created
@@ -365,14 +362,9 @@ def upload_callback(log_id: str):
365362
end_time=datetime.now(),
366363
)
367364
error_message = str(e).replace("\n", " ")
368-
if len(error_message) > 100:
369-
sys.stderr.write(
370-
f"\n{RED}Your {hl_file.type}'s `callable` failed for Datapoint: {dp.id}. Error: {error_message[:100]}...{RESET}\n"
371-
)
372-
else:
373-
sys.stderr.write(
374-
f"\n{RED}Your {hl_file.type}'s `callable` failed for Datapoint: {dp.id}. Error: {error_message}{RESET}\n"
375-
)
365+
sys.stderr.write(
366+
f"\n{RED}Your {hl_file.type}'s `callable` failed for Datapoint: {dp.id}. Error: {error_message[:100]}...{RESET}\n"
367+
)
376368

377369
with ThreadPoolExecutor(max_workers=workers) as executor:
378370
futures = []
@@ -916,8 +908,13 @@ def _run_local_evaluators(
916908
progress_bar: _SimpleProgressBar,
917909
):
918910
"""Run local Evaluators on the Log and send the judgments to Humanloop."""
919-
# Need to get the full log to pass to the evaluators
911+
# If there are no local evaluators, we don't need to do the log lookup.
912+
if len(local_evaluators) == 0:
913+
progress_bar.increment()
914+
return
915+
920916
try:
917+
# Need to get the full log to pass to the evaluators
921918
log = client.logs.get(id=log_id)
922919
if not isinstance(log, dict):
923920
log_dict = log.dict()
@@ -964,24 +961,14 @@ def _run_local_evaluators(
964961
end_time=datetime.now(),
965962
)
966963
error_message = str(e).replace("\n", " ")
967-
if len(error_message) > 100:
968-
sys.stderr.write(
969-
f"{RED}Evaluator {local_evaluator.path} failed with error {error_message[:100]}...{RESET}\n"
970-
)
971-
else:
972-
sys.stderr.write(
973-
f"{RED}Evaluator {local_evaluator.path} failed with error {error_message}{RESET}\n"
974-
)
964+
sys.stderr.write(
965+
f"{RED}Evaluator {local_evaluator.path} failed with error {error_message[:100]}...{RESET}\n"
966+
)
975967
except Exception as e:
976968
error_message = str(e).replace("\n", " ")
977-
if len(error_message) > 100:
978-
sys.stderr.write(
979-
f"{RED}Failed to run local Evaluators for source datapoint {datapoint.dict()['id'] if datapoint else None}: {error_message[:100]}...{RESET}\n"
980-
)
981-
else:
982-
sys.stderr.write(
983-
f"{RED}Failed to run local Evaluators for source datapoint {datapoint.dict()['id'] if datapoint else None}: {error_message}{RESET}\n"
984-
)
969+
sys.stderr.write(
970+
f"{RED}Failed to run local Evaluators for source datapoint {datapoint.dict()['id'] if datapoint else None}: {error_message[:100]}...{RESET}\n"
971+
)
985972
pass
986973
finally:
987974
progress_bar.increment()

0 commit comments

Comments
 (0)