Creation of new OkHttpClients instead of reusing one

[Legion1900]

Erc20Kit can work with only one token at a time. Each instance of Erc20Kit requires new TransactionManager which in turn requires EtherscanTransactionsProvider which needs EtherscanService. Each new EtherscanService creates new instance of OkHttpClient which is resource-heavy. Is there some specific reason for it?

It would be great if users will be able to provide OkHttpClient through class constructors as it allows proper resource management on app level.

[abdrasulov]

Hi @Legion1900. Thanks for your interest. That's a good point. We will work on this soon

[Legion1900]

For our project we made these hotfixes of InfuraService.kt and EtherscanService.kt. Basically we changed visibility of Retrofit services from internal to public and modified service constructors so that they accept built services.

Hope this can be helpful