Migrations need a node selector for some setups

[Vchabs]

I deploy my kubernetes cluster in a way where all my nodes are namespace specific, and pods on nodes in one namespace are security group blocked from nodes on other namespaces. I need to be able to specify a nodeSelector on the migration pods, else they are failing. I could have simply disabled the migration job and deployed this as part of a second helm chart on top but this is way simpler.

[Vchabs]

I have the code implemented, I just don't have edit access to create a PR for this

The changes are:

{{- if .Values.migrations.enabled }}
apiVersion: batch/v1
kind: Job
metadata:
  name: {{ printf "%s-migrations-%d" (include "hoppscotch.fullname" .) .Release.Revision | trunc 63 }}
  namespace: {{ include "hoppscotch.namespace" . | quote }}
  labels:
    app.kubernetes.io/component: hoppscotch-migrations
    {{- include "hoppscotch.labels" . | nindent 4 }}
  {{- if .Values.commonAnnotations }}
  annotations:
    {{- toYaml .Values.commonAnnotations | nindent 4 }}
  {{- end }}
spec:
  template:
    metadata:
      labels:
        app.kubernetes.io/component: hoppscotch-migrations
        {{- include "hoppscotch.labels" . | nindent 8 }}
    spec:
      {{- with .Values.global.imagePullSecrets }}
      imagePullSecrets:
        {{- toYaml . | nindent 8 }}
      {{- end }}
      {{- with .Values.migrations.nodeSelector }}
      nodeSelector:
        {{- toYaml . | nindent 8 }}
      {{- end }}
      restartPolicy: OnFailure
      {{- if or .Values.defaultInitContainers.waitForDatabase }}
      initContainers:
        {{- include "hoppscotch.defaultInitContainers.waitForDatabase" . | nindent 8 }}
      {{- end }}
      containers:
        - name: hoppscotch-migrations
          image: {{ include "hoppscotch.backend.image" . }}
          imagePullPolicy: {{ include "hoppscotch.backend.imagePullPolicy" . }}
          command:
            - /bin/sh
          args:
            - -c
            - ./node_modules/.bin/prisma migrate deploy
          {{- if .Values.migrations.extraEnvVars }}
          env:
            {{- toYaml .Values.migrations.extraEnvVars | nindent 12 }}
          {{- end }}
          envFrom:
            - secretRef:
                name: {{ include "hoppscotch.secretName" . }}
            {{- if .Values.migrations.extraEnvVarsCM }}
            - configMapRef:
                name: {{ .Values.migrations.extraEnvVarsCM }}
            {{- end }}
            {{- if .Values.migrations.extraEnvVarsSecret }}
            - secretRef:
                name: {{ .Values.migrations.extraEnvVarsSecret }}
            {{- end }}
          {{- $resources := include "hoppscotch.resources" (dict "preset" .Values.migrations.resourcesPreset "resources" .Values.migrations.resources) }}
          {{- if $resources }}
          resources:
            {{- $resources | nindent 12 }}
          {{- end }}
{{- end }}

and in the values file:

lines 1720-1723 of your values.yaml file:

  # -- Node labels for pod assignment
  # @section -- Hoppscotch Migrations Container Parameters
  nodeSelector: {}

[jonathanfoster]

You’ll need to fork the repo, commit to your repo, then submit a PR to the upstream repo.

I recommend adding support for affinity, tolerations, and topology spread constraints too that way we maintain consistency with other containers.

Any change should include unit test coverage. Take a look at examples in https://github.com/hoppscotch/helm-charts/tree/main/charts/hoppscotch/tests.

[Vchabs]

ok thanks - I see that you made some commits - are you planning on merging that? Should I make a separate fork/PR for this? Thanks!

[jonathanfoster]

Yeah, I’ve got a PR coming that resolves this issue as well as a few others.

[Vchabs]

Thanks a ton! Happy new year!