new attempt: install both fmt and spdlog with versions that are compatible)

Author: hmohrdaurat

velox-docker-image/Dockerfile

@@ -5,11 +5,14 @@ RUN apt-get install curl wget git build-essential sudo cmake -y
 RUN apt-get install lldb clang -y
 RUN cd /usr/local && git clone --recursive https://github.com/facebookincubator/velox.git \
     && cd velox && git checkout 3020196b001130a9027b09d6b3b95385b90bc2cb && git submodule sync --recursive && git submodule update --init --recursive
-RUN cd /usr/local/velox && ./scripts/setup-ubuntu.sh install_folly install_fizz install_wangle install_mvfst install_fbthrift install_conda
+RUN cd /usr/local/velox && ./scripts/setup-ubuntu.sh
 RUN cd /usr/local/velox && make VELOX_BUILD_TESTING=OFF
 RUN apt-get install openssh-server -y
 RUN apt install nano emacs-nox -y
 ADD ./velox.patch /usr/local/velox/
+ADD ./velox-install-compatible-spdlog.sh /usr/local/velox/scripts/install-compatible-spdlog.sh
 WORKDIR /usr/local/velox
 RUN git apply velox.patch
+RUN chmod u+x ./scripts/install-compatible-spdlog.sh
+RUN ./scripts/install-compatible-spdlog.sh
 RUN apt update && DEBIAN_FRONTEND=noninteractive apt install -yy uuid-dev libopenblas-dev libfftw3-dev liblapacke-dev

velox-docker-image/velox-install-compatible-spdlog.sh

@@ -0,0 +1,40 @@
+#!/bin/bash
+# Copyright (c) Facebook, Inc. and its affiliates.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Minimal setup for Ubuntu 20.04.
+set -eufx -o pipefail
+SCRIPTDIR=$(dirname "${BASH_SOURCE[0]}")
+source $SCRIPTDIR/setup-helper-functions.sh
+
+# Folly must be built with the same compiler flags so that some low level types
+# are the same size.
+CPU_TARGET="${CPU_TARGET:-avx}"
+COMPILER_FLAGS=$(get_cxx_flags "$CPU_TARGET")
+export COMPILER_FLAGS
+SPDLOG_VERSION=v1.12.0
+NPROC=$(getconf _NPROCESSORS_ONLN)
+DEPENDENCY_DIR=${DEPENDENCY_DIR:-$(pwd)}
+export CMAKE_BUILD_TYPE=Release
+
+function install_spdlog {
+  github_checkout gabime/spdlog "${SPDLOG_VERSION}"
+  cmake_install
+}
+
+(return 2> /dev/null) && return # If script was sourced, don't run commands.
+
+(
+  install_spdlog
+)