chore: cleanup files

Author: MarcStdt

.github/workflows/build.yml

@@ -6,8 +6,6 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - name: Install libpcap-dev
-        run: sudo apt update && sudo apt install -y libpcap-dev
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0

.github/workflows/pr.yml

@@ -6,8 +6,6 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - name: Install libpcap-dev
-        run: sudo apt update && sudo apt install -y libpcap-dev
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0

Dockerfile.testing

@@ -2,7 +2,7 @@
 FROM nginx
 WORKDIR /app
 
-RUN apt update && apt install -y ca-certificates wget jq moreutils htop procps nano net-tools gcc make libpcap-dev openjdk-17-jdk ant netcat-traditional
+RUN apt update && apt install -y ca-certificates wget jq moreutils htop procps nano net-tools gcc make openjdk-17-jdk ant netcat-traditional
 
 
 RUN wget https://go.dev/dl/go1.21.6.linux-$(dpkg --print-architecture).tar.gz -O go.tar.gz

Makefile

@@ -6,8 +6,7 @@ build: ## Build Daemon
 	CGO_ENABLED=0 go build -ldflags "-X github.com/highcard-dev/daemon/internal.Version=$(VERSION)" -o ./bin/druid
 
 build-x86-docker:
-	docker build . -f build/Dockerfile.darwin -t golang-new-builder:latest
-	docker run -e GOOS=linux -e GOARCH=amd64 -it --rm -v ./:/app -w /app --entrypoint=/bin/bash golang-new-builder:latest  -c 'CGO_ENABLED=1 go build -ldflags "-X github.com/highcard-dev/daemon/internal.Version=$(VERSION)" -o ./bin/x86/druid'
+	docker run -e GOOS=linux -e GOARCH=amd64 -it --rm -v ./:/app -w /app --entrypoint=/bin/bash docker.elastic.co/beats-dev/golang-crossbuild:1.22.5-main  -c 'CGO_ENABLED=1 go build -ldflags "-X github.com/highcard-dev/daemon/internal.Version=$(VERSION)" -o ./bin/x86/druid'
 
 install: ## Install Daemon
 	cp ./bin/druid /usr/local/bin/druid

build/Dockerfile.darwin

@@ -151,6 +151,7 @@ to interact and monitor the Scroll Application`,
 			go func() {
 				if useColdstarter {
 					if currentScroll.CanColdStart() {
+						logger.Log().Info("Starting coldstarter")
 						err = coldStarter.StartOnce(ctx)
 						if err != nil {
 							logger.Log().Error("Error in coldstarter", zap.Error(err))
@@ -286,7 +287,7 @@ func init() {
 		ServeCommand.Flags().StringArrayVarP(&watchPortsInterfaces, "watch-ports-interfaces", "", []string{"lo"}, "Interfaces to watch for port activity")
 	}
 
-	ServeCommand.Flags().BoolVarP(&useColdstarter, "coldstarter", "", true, "Use coldstarter to not start immediately")
+	ServeCommand.Flags().BoolVarP(&useColdstarter, "coldstarter", "", false, "Use coldstarter to not start immediately")
 
 	ServeCommand.Flags().BoolVarP(&ignoreVersionCheck, "ignore-version-check", "", false, "Ignore version check")
 

cmd/serve.go

@@ -70,7 +70,8 @@ func (p *PortMonitor) SyncPortEnv(file *domain.File) []*domain.AugmentedPort {
 		}
 
 		ap := &domain.AugmentedPort{
-			Port: port,
+			Port:          port,
+			InactiveSince: time.Now(),
 		}
 
 		augmentedPorts[idx] = ap

internal/core/services/port_service.go

@@ -157,17 +157,20 @@ var setupScroll = func(t *testing.T, scroll domain.File) (string, string) {
 
 var setupServeCmd = func(ctx context.Context, t *testing.T, cwd string, additionalArgs []string) {
 
+	args := append([]string{"--cwd", cwd, "serve"}, additionalArgs...)
+
 	b := bytes.NewBufferString("")
 
 	serveCmd := cmd.RootCmd
 	serveCmd.SetErr(b)
 	serveCmd.SetOut(b)
-	serveCmd.SetArgs(append([]string{"--cwd", cwd, "serve"}, additionalArgs...))
-
+	serveCmd.SetArgs(args)
 	// Create a new context for each test case
 
 	cmd.ServeCommand.SetContext(ctx)
 
+	logger.Log().Info(fmt.Sprintf("Running serve command with args: %v", args))
+
 	connected, err := startAndTestServeCommand(ctx, t, serveCmd)
 	if !connected {
 		t.Fatalf("Failed to connect to daemon web server: %v", err)
@@ -306,7 +309,7 @@ func TestColdstarterServeCommand(t *testing.T) {
 			ctx, cancel := context.WithCancelCause(context.Background())
 			defer cancel(errors.New("test ended"))
 
-			setupServeCmd(ctx, t, path, []string{})
+			setupServeCmd(ctx, t, path, []string{"--coldstarter"})
 
 			defer func() {
 				signals.Stop()

test/integration/commands/serve_coldstarter_test.go

@@ -72,7 +72,7 @@ func TestWatchPortsServeCommand(t *testing.T) {
 			ctx, cancel := context.WithCancelCause(context.Background())
 			defer cancel(errors.New("test ended"))
 
-			setupServeCmd(ctx, t, path, []string{"--watch-ports"})
+			setupServeCmd(ctx, t, path, []string{"--watch-ports", "--coldstarter=false"})
 
 			defer func() {
 				signals.Stop()