Skip to content

Commit 4df613e

Browse files
committed
fix(CI-CD): 🐛 Update env usage
1 parent af2ecdd commit 4df613e

2 files changed

Lines changed: 18 additions & 17 deletions

File tree

.github/workflows/pr-validation.yml

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
- name: Setup Node.js
3838
uses: actions/setup-node@v4
3939
with:
40-
node-version: ${{ env.NODE_VERSION }}
40+
node-version: "lts"
4141

4242
- name: Enable corepack
4343
run: corepack enable
@@ -58,35 +58,35 @@ jobs:
5858
needs: version-calculation
5959
uses: ./.github/workflows/job-build.yml
6060
with:
61-
node-version: ${{ env.NODE_VERSION }}
61+
node-version: "lts"
6262
upload-artifact: true
63-
artifact-name: ${{ env.ARTIFACT_BUILD }}
63+
artifact-name: build-${{ github.run_id }}
6464

6565
# Test job (runs in parallel with build)
6666
test:
6767
needs: version-calculation
6868
uses: ./.github/workflows/job-tests.yml
6969
with:
70-
node-version: ${{ env.NODE_VERSION }}
70+
node-version: "lts"
7171
coverage: true
7272

7373
lint:
7474
uses: ./.github/workflows/job-lint.yml
7575
with:
76-
node-version: ${{ env.NODE_VERSION }}
76+
node-version: "lts"
7777

7878
type-check:
7979
uses: ./.github/workflows/job-typecheck.yml
8080
with:
81-
node-version: ${{ env.NODE_VERSION }}
81+
node-version: "lts"
8282

8383
# Verification job (depends on build for artifacts)
8484
verification:
8585
needs: [build, test]
8686
uses: ./.github/workflows/job-verification.yml
8787
with:
88-
node-version: ${{ env.NODE_VERSION }}
89-
build-artifact: ${{ env.ARTIFACT_BUILD }}
88+
node-version: "lts"
89+
build-artifact: build-${{ github.run_id }}
9090

9191
# PR comment with results
9292
pr-comment:
@@ -149,12 +149,13 @@ jobs:
149149
return `| ${status.icon} | **${metric}** | ${bar} | **${value}%** |`;
150150
}).join('\n');
151151
152-
const header = `
153-
> ${avgStatus.icon} **Overall Coverage: ${avgCoverage}%** ${avgStatus.label === 'perfect' ? '— Target reached! 🎯' : '— Target: ' + target + '%'}
154-
155-
| | Metric | Progress | Coverage |
156-
|:---:|--------|:--------:|:--------:|
157-
${rows}`;
152+
const header = [
153+
`> ${avgStatus.icon} **Overall Coverage: ${avgCoverage}%** ${avgStatus.label === 'perfect' ? '— Target reached! 🎯' : '— Target: ' + target + '%'}`,
154+
'',
155+
'| | Metric | Progress | Coverage |',
156+
'|:---:|--------|:--------:|:--------:|',
157+
rows,
158+
].join('\n');
158159
159160
return header;
160161
};

.github/workflows/release.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,21 +50,21 @@ jobs:
5050
needs: repo-guard
5151
uses: ./.github/workflows/job-lint.yml
5252
with:
53-
node-version: ${{ env.NODE_VERSION }}
53+
node-version: "lts"
5454

5555
# Step 3: Type check
5656
type-check:
5757
needs: repo-guard
5858
uses: ./.github/workflows/job-typecheck.yml
5959
with:
60-
node-version: ${{ env.NODE_VERSION }}
60+
node-version: "lts"
6161

6262
# Step 4: Tests
6363
tests:
6464
needs: repo-guard
6565
uses: ./.github/workflows/job-tests.yml
6666
with:
67-
node-version: ${{ env.NODE_VERSION }}
67+
node-version: "lts"
6868

6969
# Step 2: Build and verify
7070
build-and-verify:

0 commit comments

Comments
 (0)