Skip to content
This repository was archived by the owner on Oct 17, 2023. It is now read-only.

Commit dd09806

Browse files
authored
Merge pull request #82 from hellosign/Travis
Fixes for unit tests and Travis CI
2 parents 4e4793a + 4887cbc commit dd09806

4 files changed

Lines changed: 13 additions & 4 deletions

File tree

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
## HelloSign PHP SDK
2+
[![Build Status](https://travis-ci.org/hellosign/hellosign-php-sdk.svg?branch=v3)](https://travis-ci.org/hellosign/hellosign-php-sdk)
23

34
This is the official PHP SDK for HelloSign's API. [View API Documentation and Examples.](https://app.hellosign.com/api/documentation)
45

library/HelloSign/BulkSendJob.php

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,15 @@ public function getSignatureRequests()
184184
*/
185185
public function __construct($response = null, $options = array())
186186
{
187-
$this->signature_requests = $response->signature_requests;
188-
$this->list_info = $response->list_info;
187+
if (isset($response->signature_requests))
188+
{
189+
$this->signature_requests = $response->signature_requests;
190+
}
191+
192+
if (isset($response->list_info))
193+
{
194+
$this->list_info = $response->list_info;
195+
}
189196

190197
parent::__construct($response, $options);
191198
}

library/HelloSign/Client.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
class Client
4242
{
4343

44-
const VERSION = '3.5.5';
44+
const VERSION = '3.5.6';
4545

4646
const API_URL = "https://api.hellosign.com/v3/";
4747

library/HelloSign/Test/TemplateTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,8 @@ public function testUpdateTemplateFiles()
187187
{
188188
$templates = $this->client->getTemplates();
189189
$template_id = $templates[0]->getId();
190-
190+
$client_id = $_ENV['CLIENT_ID'];
191+
191192
$request = new \HelloSign\Template();
192193
$request->enableTestMode();
193194
$request->setClientId($client_id);

0 commit comments

Comments
 (0)