fixup! [IMP] base v19 migration (NOT DONE)

Author: hbrunn

openupgrade_scripts/scripts/base/19.0.1.3/post-migration.py

@@ -29,7 +29,58 @@ def _ir_actions_server_child_ids(env):
     )
 
 
+def _ir_actions_server_html_value(env):
+    """
+    For evaluation_type 'value' and update_field_id.ttype == 'html',
+    new field html_value is used
+    """
+    for action in env["ir.actions.server"].search(
+        [
+            ("state", "=", "object_write"),
+            ("evaluation_type", "=", "value"),
+            ("update_field_id.ttype", "=", "html"),
+        ]
+    ):
+        action.write({"html_value": action.value})
+
+
+def _ir_filters_user_ids(env):
+    """
+    m2o user_id has been transformed to m2m user_ids
+    """
+    openupgrade.m2o_to_x2m(
+        env.cr, env["ir.filters"], env["ir.filters"]._table, "user_ids", "user_id"
+    )
+
+
+def _res_lang(env):
+    """
+    Char fields date_format, grouping and time_format have been dumbed down to
+    selection fields. Keep their original value in a legacy column, and map existing
+    values not in the selection to the default value
+    """
+    ResLang = env["res.lang"]
+    for field_name in ("date_format", "time_format", "grouping"):
+        field = ResLang._fields[field_name]
+        openupgrade.copy_columns(env.cr, {"res_lang": [(field_name, None, None)]})
+        openupgrade.logged_query(
+            env.cr,
+            f"UPDATE res_lang SET {field_name}=%(default)s "
+            f"WHERE {field_name} NOT IN %(selection)s",
+            {
+                "default": field.default(ResLang),
+                "selection": tuple(
+                    value for value, _string in field._description_selection(env)
+                ),
+            },
+        )
+
+
 @openupgrade.migrate()
 def migrate(env, version):
+    openupgrade.load_data(env, "base", "19.0.1.3/noupdate_changes.xml")
     _ir_actions_act_window_target(env)
     _ir_actions_server_child_ids(env)
+    _ir_actions_server_html_value(env)
+    _ir_filters_user_ids(env)
+    _res_lang(env)

openupgrade_scripts/scripts/base/19.0.1.3/pre-migration.py

@@ -122,6 +122,30 @@
         "groups_id",
         "group_ids",
     ),
+    (
+        "ir.actions.server",
+        "ir_act_report_xml",
+        "groups_id",
+        "group_ids",
+    ),
+    (
+        "ir.ui.menu",
+        "ir_ui_menu",
+        "groups_id",
+        "group_ids",
+    ),
+    (
+        "ir.ui.view",
+        "ir_ui_view",
+        "groups_id",
+        "group_ids",
+    ),
+    (
+        "res.groups",
+        "res_groups",
+        "users",
+        "user_ids",
+    ),
 ]
 
 

openupgrade_scripts/scripts/base/19.0.1.3/upgrade_analysis_work.txt

@@ -45,77 +45,194 @@ base         / ir.actions.server        / child_ids (many2many)         : type i
 # DONE: set from m2m table in post-migration
 
 base         / ir.actions.server        / crud_model_id (many2one)      : now a function
+
+# NOTHING TO DO: same computation function
+
 base         / ir.actions.server        / evaluation_type (selection)   : selection_keys added: [sequence] (most likely nothing to do)
+
+# NOTHING TO DO
+
 base         / ir.actions.server        / group_ids (many2many)         : NEW relation: res.groups
 base         / ir.actions.server        / groups_id (many2many)         : DEL relation: res.groups
+
+# DONE: renamed groups_id to group_ids in pre-migration
+
 base         / ir.actions.server        / html_value (html)             : NEW
+
+# DONE: filled from value in post-migration
+
 base         / ir.actions.server        / ir_cron_ids (one2many)        : NEW relation: ir.cron
+
+# NOTHING TO DO: inverse of ir.cron#ir_actions_server_id
+
 base         / ir.actions.server        / model_name (char)             : not stored anymore
+
+# NOTHING TO DO
+
 base         / ir.actions.server        / parent_id (many2one)          : NEW relation: ir.actions.server
+
+# DONE: see above for child_ids
+
 base         / ir.actions.server        / sequence_id (many2one)        : NEW relation: ir.sequence
+
+# NOTHING TO DO: new field for evaluation_type == 'sequence'
+
 base         / ir.actions.server        / state (selection)             : selection_keys added: [object_copy] (most likely nothing to do)
 base         / ir.actions.server        / value_field_to_show (selection): selection_keys added: [html_value, sequence_id] (most likely nothing to do)
+
+# NOTHING TO DO
+
 base         / ir.actions.server.history / action_id (many2one)          : NEW relation: ir.actions.server, required
 base         / ir.actions.server.history / code (text)                   : NEW
+
+# NOTHING TO DO: v19 keeps a history of code changes
+
 base         / ir.cron                  / _order                        : _order is now 'cron_name, id' ('cron_name')
+
+# NOTHING TO DO
+
 base         / ir.cron                  / child_ids (many2many)         : type is now 'one2many' ('many2many')
+
+# NOTHING TO DO: inherited from ir.actions.server, handled there
+
 base         / ir.cron.trigger          / call_at (datetime)            : now required
 base         / ir.cron.trigger          / cron_id (many2one)            : now required
+
+# NOTHING TO DO: old records with missing fields will be cleaned up eventually
+
 base         / ir.exports               / _order                        : _order is now 'name, id' ('name')
+
+# NOTHING TO DO
+
 base         / ir.filters               / user_id (many2one)            : DEL relation: res.users
 base         / ir.filters               / user_ids (many2many)          : NEW relation: res.users
+
+# DONE: openupgrade.m2o_to_x2m in post-migration
+
 base         / ir.mail_server           / smtp_encryption (selection)   : selection_keys added: [ssl_strict, starttls_strict] (most likely nothing to do)
+
+# NOTHING TO DO
+
 base         / ir.model                 / abstract (boolean)            : NEW
 base         / ir.model                 / fold_name (char)              : NEW
+
+# NOTHING TO DO: filled by orm
+
 base         / ir.model.fields          / _order                        : _order is now 'name, id' ('name')
 base         / ir.model.fields          / complete_name (char)          : DEL
+
+# NOTHING TO DO
+
 base         / ir.model.fields          / translate (boolean)           : selection_keys is now '['html_translate', 'standard', 'xml_translate']' ('False')
 base         / ir.model.fields          / translate (boolean)           : type is now 'selection' ('boolean')
 
 # DONE: set column to NULL where it was FALSE in openupgrade_framework, because migration scripts are too late for it
 
 base         / ir.module.category       / _order                        : _order is now 'sequence, name, id' ('name')
+
+# NOTHING TO DO: we want to have the ordering by sequence as provided by Odoo
+
 base         / ir.module.category       / privilege_ids (one2many)      : NEW relation: res.groups.privilege
+
+# NOTHING TO DO: new concept
+
 base         / ir.profile               / cpu_duration (float)          : NEW
 base         / ir.profile               / others (text)                 : NEW
+
+# NOTHING TO DO: new funcitonality, no way of generating this data
+
 base         / ir.sequence              / _order                        : _order is now 'name, id' ('name')
+
+# NOTHING TO DO
+
 base         / ir.ui.menu               / group_ids (many2many)         : NEW relation: res.groups
 base         / ir.ui.menu               / groups_id (many2many)         : DEL relation: res.groups
 base         / ir.ui.view               / group_ids (many2many)         : NEW relation: res.groups
 base         / ir.ui.view               / groups_id (many2many)         : DEL relation: res.groups
+
+# DONE: renamed groups_id to group_ids in pre-migration
+
 base         / ir.ui.view.custom        / _order                        : _order is now 'create_date desc, id desc' ('create_date desc')
+
+# NOTHING TO DO
+
 base         / properties.base.definition / properties_definition (properties_definition): NEW
 base         / properties.base.definition / properties_field_id (many2one): NEW relation: ir.model.fields, required
+
+# NOTHING TO DO: filled by orm
+
 base         / report.layout            / _order                        : _order is now 'sequence, id' ('sequence')
 base         / res.bank                 / _order                        : _order is now 'name, id' ('name')
 base         / res.company              / company_registry_placeholder (char): previously in module account
+
+# NOTHING TO DO
+
 base         / res.company              / mobile (char)                 : DEL
+
+# NOTHING TO DO: possibly some oca module will pick this up again
+
 base         / res.country              / _order                        : _order is now 'name, id' ('name')
+
+# NOTHING TO DO: possibly some oca module will pick this up again
+
 base         / res.country.group        / code (char)                   : NEW
+
+# NOTHING TO DO: filled in noupdate_changes.xml
+
 base         / res.country.state        / _order                        : _order is now 'code, id' ('code')
 base         / res.currency.rate        / _order                        : _order is now 'name desc, id' ('name desc')
 base         / res.groups               / _order                        : _order is now 'privilege_id, sequence, name, id' ('name')
+
+# NOTHING TO DO
+
 base         / res.groups               / category_id (many2one)        : DEL relation: ir.module.category
+
+# NOTHING TO DO: code provided groups will set their own privilege if applicable, manually created ones will have to be assigned to whatever privilege makes sense
+
 base         / res.groups               / color (integer)               : DEL
+
+# NOTHING TO DO
+
 base         / res.groups               / implied_by_ids (many2many)    : NEW relation: res.groups
+
+# NOTHING TO DO: inverse of existing relation
+
 base         / res.groups               / privilege_id (many2one)       : NEW relation: res.groups.privilege
+
+# NOTHING TO DO: new concept
+
 base         / res.groups               / sequence (integer)            : NEW
+
+# NOTHING TO DO
+
 base         / res.groups               / user_ids (many2many)          : NEW relation: res.users
 base         / res.groups               / users (many2many)             : DEL relation: res.users
+
+# DONE: renamed field in pre-migration
+
 base         / res.groups.privilege     / category_id (many2one)        : NEW relation: ir.module.category
 base         / res.groups.privilege     / description (text)            : NEW
 base         / res.groups.privilege     / group_ids (one2many)          : NEW relation: res.groups
 base         / res.groups.privilege     / name (char)                   : NEW required, translate
 base         / res.groups.privilege     / placeholder (char)            : NEW hasdefault: default
 base         / res.groups.privilege     / sequence (integer)            : NEW hasdefault: default
+
+# NOTHING TO DO: new concept
+
 base         / res.lang                 / date_format (char)            : selection_keys is now 'function' ('False')
 base         / res.lang                 / date_format (char)            : type is now 'selection' ('char')
 base         / res.lang                 / grouping (char)               : selection_keys is now '['[3,0]', '[3,2,0]']' ('False')
 base         / res.lang                 / grouping (char)               : type is now 'selection' ('char')
 base         / res.lang                 / short_time_format (char)      : DEL required
 base         / res.lang                 / time_format (char)            : selection_keys is now '['%H:%M:%S', '%I:%M:%S %p']' ('False')
 base         / res.lang                 / time_format (char)            : type is now 'selection' ('char')
+
+# DONE: copy original values to legacy column, map values not in selection to default value
+
 base         / res.partner              / mobile (char)                 : DEL
+
+# NOTHING TO DO: possibly some oca module will pick this up again
+
 base         / res.partner              / properties (properties)       : NEW hasdefault: compute
 base         / res.partner              / title (many2one)              : DEL relation: res.partner.title
 base         / res.partner.bank         / clearing_number (char)        : NEW