gitlab.nvim/cmd/app/draft_notes_test.go at 15fd7d6892f7461a22cf109859b57f85ef4b836a · harrisoncramer/gitlab.nvim · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
package app

import (
	"net/http"
	"testing"

	gitlab "gitlab.com/gitlab-org/api/client-go"
)

type fakeDraftNoteManager struct {
	testBase
}

func (f fakeDraftNoteManager) ListDraftNotes(pid interface{}, mergeRequest int, opt *gitlab.ListDraftNotesOptions, options ...gitlab.RequestOptionFunc) ([]*gitlab.DraftNote, *gitlab.Response, error) {
	resp, err := f.handleGitlabError()
	if err != nil {
		return nil, nil, err
	}
	return []*gitlab.DraftNote{}, resp, err
}

func (f fakeDraftNoteManager) CreateDraftNote(pid interface{}, mergeRequest int, opt *gitlab.CreateDraftNoteOptions, options ...gitlab.RequestOptionFunc) (*gitlab.DraftNote, *gitlab.Response, error) {
	resp, err := f.handleGitlabError()
	if err != nil {
		return nil, nil, err
	}
	return &gitlab.DraftNote{}, resp, err
}

func (f fakeDraftNoteManager) DeleteDraftNote(pid interface{}, mergeRequest int, note int, options ...gitlab.RequestOptionFunc) (*gitlab.Response, error) {
	return f.handleGitlabError()
}

func (f fakeDraftNoteManager) UpdateDraftNote(pid interface{}, mergeRequest int, note int, opt *gitlab.UpdateDraftNoteOptions, options ...gitlab.RequestOptionFunc) (*gitlab.DraftNote, *gitlab.Response, error) {
	resp, err := f.handleGitlabError()
	if err != nil {
		return nil, nil, err
	}
	return &gitlab.DraftNote{}, resp, err
}

func TestListDraftNotes(t *testing.T) {
	t.Run("Lists all draft notes", func(t *testing.T) {
		request := makeRequest(t, http.MethodGet, "/mr/draft_notes/", nil)
		svc := middleware(
			draftNoteService{testProjectData, fakeDraftNoteManager{}},
			withMr(testProjectData, fakeMergeRequestLister{}),
			withPayloadValidation(methodToPayload{
				http.MethodPost:  newPayload[PostDraftNoteRequest],
				http.MethodPatch: newPayload[UpdateDraftNoteRequest],
			}),
			withMethodCheck(http.MethodGet, http.MethodPost, http.MethodPatch, http.MethodDelete),
		)

		data := getSuccessData(t, svc, request)
		assert(t, data.Message, "Draft notes fetched successfully")
	})
	t.Run("Handles error from Gitlab client", func(t *testing.T) {
		request := makeRequest(t, http.MethodGet, "/mr/draft_notes/", nil)
		svc := middleware(
			draftNoteService{testProjectData, fakeDraftNoteManager{testBase: testBase{errFromGitlab: true}}},
			withMr(testProjectData, fakeMergeRequestLister{}),
			withPayloadValidation(methodToPayload{
				http.MethodPost:  newPayload[PostDraftNoteRequest],
				http.MethodPatch: newPayload[UpdateDraftNoteRequest],
			}),
			withMethodCheck(http.MethodGet, http.MethodPost, http.MethodPatch, http.MethodDelete),
		)
		data, _ := getFailData(t, svc, request)
		checkErrorFromGitlab(t, data, "Could not get draft notes")
	})
	t.Run("Handles non-200s from Gitlab client", func(t *testing.T) {
		request := makeRequest(t, http.MethodGet, "/mr/draft_notes/", nil)
		svc := middleware(
			draftNoteService{testProjectData, fakeDraftNoteManager{testBase: testBase{status: http.StatusSeeOther}}},
			withMr(testProjectData, fakeMergeRequestLister{}),
			withPayloadValidation(methodToPayload{
				http.MethodPost:  newPayload[PostDraftNoteRequest],
				http.MethodPatch: newPayload[UpdateDraftNoteRequest],
			}),
			withMethodCheck(http.MethodGet, http.MethodPost, http.MethodPatch, http.MethodDelete),
		)
		data, _ := getFailData(t, svc, request)
		checkNon200(t, data, "Could not get draft notes", "/mr/draft_notes/")
	})
}

func TestPostDraftNote(t *testing.T) {
	var testPostDraftNoteRequestData = PostDraftNoteRequest{
		Comment:      "Some comment",
		DiscussionId: "abc123",
	}
	t.Run("Posts new draft note", func(t *testing.T) {
		request := makeRequest(t, http.MethodPost, "/mr/draft_notes/", testPostDraftNoteRequestData)
		svc := middleware(
			draftNoteService{testProjectData, fakeDraftNoteManager{}},
			withMr(testProjectData, fakeMergeRequestLister{}),
			withPayloadValidation(methodToPayload{
				http.MethodPost:  newPayload[PostDraftNoteRequest],
				http.MethodPatch: newPayload[UpdateDraftNoteRequest],
			}),
			withMethodCheck(http.MethodGet, http.MethodPost, http.MethodPatch, http.MethodDelete),
		)
		data := getSuccessData(t, svc, request)
		assert(t, data.Message, "Draft note created successfully")
	})
}

func TestDeleteDraftNote(t *testing.T) {
	t.Run("Deletes new draft note", func(t *testing.T) {
		request := makeRequest(t, http.MethodDelete, "/mr/draft_notes/3", nil)
		svc := middleware(
			draftNoteService{testProjectData, fakeDraftNoteManager{}},
			withMr(testProjectData, fakeMergeRequestLister{}),
			withPayloadValidation(methodToPayload{
				http.MethodPost:  newPayload[PostDraftNoteRequest],
				http.MethodPatch: newPayload[UpdateDraftNoteRequest],
			}),
			withMethodCheck(http.MethodGet, http.MethodPost, http.MethodPatch, http.MethodDelete),
		)
		data := getSuccessData(t, svc, request)
		assert(t, data.Message, "Draft note deleted")
	})
	t.Run("Handles bad ID", func(t *testing.T) {
		request := makeRequest(t, http.MethodDelete, "/mr/draft_notes/blah", nil)
		svc := middleware(
			draftNoteService{testProjectData, fakeDraftNoteManager{}},
			withMr(testProjectData, fakeMergeRequestLister{}),
			withPayloadValidation(methodToPayload{
				http.MethodPost:  newPayload[PostDraftNoteRequest],
				http.MethodPatch: newPayload[UpdateDraftNoteRequest],
			}),
			withMethodCheck(http.MethodGet, http.MethodPost, http.MethodPatch, http.MethodDelete),
		)
		data, status := getFailData(t, svc, request)
		assert(t, data.Message, "Could not parse draft note ID")
		assert(t, status, http.StatusBadRequest)
	})
}

func TestEditDraftNote(t *testing.T) {
	var testUpdateDraftNoteRequest = UpdateDraftNoteRequest{Note: "Some new note"}
	t.Run("Edits new draft note", func(t *testing.T) {
		request := makeRequest(t, http.MethodPatch, "/mr/draft_notes/3", testUpdateDraftNoteRequest)
		svc := middleware(
			draftNoteService{testProjectData, fakeDraftNoteManager{}},
			withMr(testProjectData, fakeMergeRequestLister{}),
			withPayloadValidation(methodToPayload{
				http.MethodPost:  newPayload[PostDraftNoteRequest],
				http.MethodPatch: newPayload[UpdateDraftNoteRequest],
			}),
			withMethodCheck(http.MethodGet, http.MethodPost, http.MethodPatch, http.MethodDelete),
		)
		data := getSuccessData(t, svc, request)
		assert(t, data.Message, "Draft note updated")
	})
	t.Run("Handles bad ID", func(t *testing.T) {
		request := makeRequest(t, http.MethodPatch, "/mr/draft_notes/blah", testUpdateDraftNoteRequest)
		svc := middleware(
			draftNoteService{testProjectData, fakeDraftNoteManager{}},
			withMr(testProjectData, fakeMergeRequestLister{}),
			withPayloadValidation(methodToPayload{
				http.MethodPost:  newPayload[PostDraftNoteRequest],
				http.MethodPatch: newPayload[UpdateDraftNoteRequest],
			}),
			withMethodCheck(http.MethodGet, http.MethodPost, http.MethodPatch, http.MethodDelete),
		)
		data, status := getFailData(t, svc, request)
		assert(t, data.Message, "Could not parse draft note ID")
		assert(t, status, http.StatusBadRequest)
	})
	t.Run("Handles empty note", func(t *testing.T) {
		requestData := testUpdateDraftNoteRequest
		requestData.Note = ""
		request := makeRequest(t, http.MethodPatch, "/mr/draft_notes/3", requestData)
		svc := middleware(
			draftNoteService{testProjectData, fakeDraftNoteManager{}},
			withMr(testProjectData, fakeMergeRequestLister{}),
			withPayloadValidation(methodToPayload{
				http.MethodPost:  newPayload[PostDraftNoteRequest],
				http.MethodPatch: newPayload[UpdateDraftNoteRequest],
			}),
			withMethodCheck(http.MethodGet, http.MethodPost, http.MethodPatch, http.MethodDelete),
		)
		data, status := getFailData(t, svc, request)
		assert(t, data.Message, "Invalid payload")
		assert(t, data.Details, "Note is required")
		assert(t, status, http.StatusBadRequest)
	})
}