-
Notifications
You must be signed in to change notification settings - Fork 9
Open
Labels
bugSomething isn't workingSomething isn't working
Description
CachingBeaconChainSpec::hash_tree_root can be passed with a mutable object, e.g. MutableBeaconState or WriteList/WriteVector. Thus it can return wrong value, if the mutable object is modified, since the caching code uses Object identity (BeaconStateImple::hashCode is not overridden).
There are several possible ways to solve the problem:
- implement proper
BeaconStateImple::hashCodeto match theBeaconStateImple::equalsimplementation - Invalidate cache based on updates
- Do not cache mutable objects. This will require implementing an appropriate flag/interface to manifest (im)mutability.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working