Skip to content

ForkChoice::get_head doesn't break ties properly #196

@ericsson49

Description

@ericsson49

fork_choice/get_head specifies, that when choosing the heaviest child, ties should be broken lexicographically:

# Sort by latest attesting balance with ties broken lexicographically

However, Harmony implementation sorts by latest balance only.
head = children.stream().max(Comparator.comparing(root -> get_latest_attesting_balance(store, root))).get();

Metadata

Metadata

Assignees

No one assigned

    Labels

    invalidThis doesn't seem rightspecChanges related to spec

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions