Skip to content

Commit 03d006d

Browse files
committed
build: Hardcoded PHP patch versions for running tests instead of getting the latest dynamically from hub.docker.com every time.
1 parent 102761c commit 03d006d

2 files changed

Lines changed: 10 additions & 17 deletions

File tree

Makefile

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@ COVERAGE_PHP := 7.4 3.1.1
66
PHP_8_3 := 8.3 3.3.2
77

88
define PHP_VERSIONS
9-
"7.2 3.1.5"\
10-
"7.3 3.1.5"\
11-
"7.4 3.1.5"\
12-
"8.0 3.4.7"\
13-
"8.1 3.4.7"\
14-
"8.2 3.4.7"\
15-
"8.3 3.4.7"\
16-
"8.4 3.4.7"\
17-
"8.5 3.5.0"
9+
"7.2.34 3.1.5"\
10+
"7.3.33 3.1.5"\
11+
"7.4.33 3.1.5"\
12+
"8.0.30 3.4.7"\
13+
"8.1.34 3.4.7"\
14+
"8.2.30 3.4.7"\
15+
"8.3.30 3.4.7"\
16+
"8.4.19 3.4.7"\
17+
"8.5.4 3.5.0"
1818
endef
1919

2020
define DOCKER_RUN

build/build-image.sh

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,12 @@
22

33
set -e
44

5-
PHP_MINOR=$1
6-
PHP_VERSION=$( (wget -qO- "https://hub.docker.com/v2/repositories/library/php/tags?page_size=100&name=$PHP_MINOR" \
7-
| grep -Po "[0-9]+\.[0-9]+\.[0-9]+(?=-)" \
8-
|| echo "$PHP_MINOR") \
9-
| head -1 \
10-
)
5+
PHP_VERSION=$1
116
XDEBUG_VERSION=$2
127

13-
148
FROM_IMAGE="php:$PHP_VERSION-cli-alpine"
159
CONTAINER_NAME="json-machine-php-$PHP_VERSION"
1610

17-
1811
docker ps --all --format "{{.Names}}" | grep "$CONTAINER_NAME" && docker rm -f "$CONTAINER_NAME"
1912

2013
>&2 echo "Building $CONTAINER_NAME from $FROM_IMAGE"

0 commit comments

Comments
 (0)