Skip to content

Commit 164859b

Browse files
authored
HCK-14608: fix configurations and FE of compression in hash partitions (#222)
1 parent 9877f7a commit 164859b

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

forward_engineering/ddlProvider/ddlHelpers/tableHelper.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ module.exports = ({ getColumnsList, checkAllKeysDeactivated, commentIfDeactivate
135135
}
136136
return getColumnsList(value.partitionKey, isAllColumnsDeactivated, isParentActivated, ({ name }) =>
137137
prepareName(name),
138-
);
138+
).trim();
139139
};
140140

141141
const getPartitionClause = (value, isActivated) => {
@@ -191,7 +191,8 @@ module.exports = ({ getColumnsList, checkAllKeysDeactivated, commentIfDeactivate
191191
case 'composite hash': {
192192
const subpartition = getSubpartition(value, isActivated);
193193
const hashPartition = getHashPartition(value);
194-
return `${subpartition}${hashPartition}`;
194+
const compression = value.compression ?? '';
195+
return ' ' + `${subpartition}${hashPartition} ${compression}`.trim();
195196
}
196197
default: {
197198
return '';

properties_pane/entity_level/entityLevelConfig.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -642,10 +642,10 @@ making sure that you maintain a proper JSON format.
642642
{
643643
"propertyName": "Compression",
644644
"propertyKeyword": "compression",
645-
"propertyTooltip": "Choose the desired hashing type",
646-
"propertyType": "select",
647-
"defaultValue": "",
648-
"options": ["", "table", "index"],
645+
"propertyTooltip": "Enter the compression description for the partition.",
646+
"propertyType": "details",
647+
"template": "textarea",
648+
"markdown": false,
649649
"dependency": {
650650
"type": "and",
651651
"values": [

0 commit comments

Comments
 (0)