Skip to content

Commit 725db43

Browse files
authored
As the modal is not dynamic at all we are force to rollback to a more usable state (#92)
1 parent db6d143 commit 725db43

2 files changed

Lines changed: 2 additions & 16 deletions

File tree

reverse_engineering/connection_settings_modal/connectionSettingsModalConfig.json

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -19,21 +19,7 @@
1919
"inputKeyword": "projectId",
2020
"inputType": "text",
2121
"inputTooltip": "Project ID on Google Cloud Platform",
22-
"dependency": {
23-
"key": "authType",
24-
"value": "app_default_credentials"
25-
}
26-
},
27-
{
28-
"inputLabel": "Project ID",
29-
"inputKeyword": "optionalProjectId",
30-
"inputType": "text",
31-
"inputPlaceholder": "Optional",
32-
"inputTooltip": "Project ID on Google Cloud Platform",
33-
"dependency": {
34-
"key": "authType",
35-
"value": "service_account_key"
36-
}
22+
"inputPlaceholder": "Optional if using service account"
3723
},
3824
{
3925
"inputLabel": "Dataset name",

reverse_engineering/helpers/connectionHelper.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ function getAuthInfo({ authType, connectionInfo }) {
1414
}
1515
// service account case and backward compatible value
1616
return {
17-
projectId: connectionInfo?.optionalProjectId,
17+
projectId: connectionInfo.projectId,
1818
credentialsFilePath: connectionInfo.keyFilename,
1919
};
2020
}

0 commit comments

Comments
 (0)