fix: comments change hasSharedDragItem to ref dragStateRef, sharedDragPositionRef

Author: daniil-filippov-dev

src/components/GridLayout/GridLayout.tsx

@@ -5,8 +5,8 @@ import type {DragOverEvent} from 'react-grid-layout';
 import type {PluginRef, PluginWidgetProps, ReactGridLayoutProps} from 'src/typings';
 
 import {COMPACT_TYPE_HORIZONTAL_NOWRAP, DEFAULT_GROUP, TEMPORARY_ITEM_ID} from '../../constants';
-import {DashKitContext} from '../../context';
 import type {DashKitCtxShape} from '../../context';
+import {DashKitContext} from '../../context';
 import type {ConfigItem, ConfigLayout, DraggedOverItem} from '../../shared';
 import {resolveLayoutGroup} from '../../utils';
 import GridItem from '../GridItem/GridItem';
@@ -205,9 +205,7 @@ export default class GridLayout extends React.PureComponent<GridLayoutProps, Gri
         renderLayout: ConfigLayout[],
         nextProperties: Partial<ReactGridLayoutProps>,
     ) => {
-        // Return a stable properties reference when values are shallowly equal.
-        // This prevents useMemo inside GroupLayout from invalidating on every render
-        // when groupGridProperties() returns a structurally identical but new object.
+        // Return stable ref to prevent useMemo invalidation when properties are shallowly equal.
         const prevProperties = this._memoGroupsProps[group];
         const keysNext = Object.keys(nextProperties) as Array<keyof ReactGridLayoutProps>;
         const stableProperties =
@@ -369,8 +367,7 @@ export default class GridLayout extends React.PureComponent<GridLayoutProps, Gri
                 cursorPosition: {offsetX, offsetY},
             };
 
-            // Update imperatively so DragOverLayout can read cursor offset without
-            // a React prop change (and thus without re-rendering non-source groups).
+            // Update imperatively so DragOverLayout reads fresh cursor offset without re-render.
             this._sharedDragPositionRef.current = {offsetX, offsetY};
         }
 
@@ -804,10 +801,7 @@ export default class GridLayout extends React.PureComponent<GridLayoutProps, Gri
                 ? currentDraggingElement.item.id
                 : null;
 
-        // Scope drag props to the source group only.
-        // Non-source groups receive stable false/null values so their React.memo
-        // comparator does not see a change on these three props — only hasSharedDragItem
-        // can still trigger their re-render (required for cross-group drop readiness).
+        // Non-source groups get stable false/null — memo skips re-render on drag move.
         const isSourceGroup = Boolean(currentDraggingElement?.group === group);
         const groupIsAnyDragging = isDragging && isSourceGroup;
         const groupCurrentDraggingItemId = isSourceGroup ? currentDraggingItemId : null;

src/components/GridLayout/GroupLayout.tsx

@@ -21,9 +21,7 @@ export interface GroupLayoutProps {
     layout: ConfigLayout[];
     temporaryPlaceholder: React.ReactNode;
 
-    // Drag state specific to this group (computed in GridLayout.renderGroup)
-    // hasSharedDragItem and sharedDragPosition replaced by stable refs read
-    // imperatively by DragOverLayout — no React prop change on drag start.
+    // Refs read imperatively by DragOverLayout — no re-render on drag start.
     isDragCaptured: boolean;
     dragStateRef: React.MutableRefObject<{isDragging: boolean; sourceGroup: string | null}>;
     sharedDragPositionRef: React.MutableRefObject<{offsetX: number; offsetY: number} | null>;
@@ -75,9 +73,7 @@ function groupLayoutPropsAreEqual(prev: GroupLayoutProps, next: GroupLayoutProps
         return false;
     }
 
-    // Re-render if drag state scoped to this group changed.
-    // hasSharedDragItem and sharedDragPosition are now refs — same object reference
-    // forever — so they never trigger a re-render here.
+    // Re-render only on group-scoped props; drag refs are stable, never trigger this.
     if (
         prev.isDragCaptured !== next.isDragCaptured ||
         prev.isAnyDragging !== next.isAnyDragging ||
@@ -128,12 +124,7 @@ export const GroupLayout = React.memo(function GroupLayout({
     // otherwise fall back to the dashboard-level noOverlay from context.
     const resolvedNoOverlay = 'noOverlay' in properties ? properties.noOverlay : noOverlay;
 
-    // Memoize the items element array so that when GroupLayout re-renders due to
-    // hasSharedDragItem changing (all non-source groups become drop-ready on drag start),
-    // the items subtree is not recreated if the drag-relevant props are unchanged.
-    // For non-source groups isAnyDragging/currentDraggingItemId/isAnyDraggedOut are
-    // scoped to stable false/null by GridLayout.renderGroup, so the cached array is
-    // returned and React skips all GridItem subtrees entirely.
+    // Memoize items array; non-source groups have stable false/null drag props so React skips their subtrees.
     const itemElements = React.useMemo(() => {
         return renderItems.map((item, i) => {
             const keyId = item.id;

src/components/GridLayout/ReactGridLayout.tsx

@@ -326,11 +326,7 @@ class DragOverLayout extends ReactGridLayout {
             return gridItem;
         }
 
-        // When a transformScaleRef is provided, inject a lazy proxy so that
-        // react-draggable reads the fresh scale via valueOf() at drag time
-        // instead of the stale number baked into the last rendered props.
-        // This avoids a re-render requirement when the canvas scale changes
-        // (e.g. after d3-zoom auto-fit) before the user starts dragging.
+        // Lazy proxy for transformScaleRef so react-draggable reads fresh scale without re-render.
         const {transformScaleRef} = this.props;
         const lazyScale = transformScaleRef
             ? ({valueOf: () => transformScaleRef.current} as unknown as number)